-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are there too many logs by default? #8132
Comments
Can't we just set WARN as default level? |
Please not (1) -- this was intentional. Logs are meant to be verbose. See my PR point (1) under Note, most of these logs are from Tendermint anyway. However, some of the SDK logs, especially the invariance checks can be |
That won't show any logs at startup, in general. Warn logs are quite rare. |
For the actionable item here, I would suggest we groom the SDK for all logs and ensure the levels are correct. This should be pretty straightforward because there aren't too many logs. We can also collect a list of logs that we think should be debug/warn in Tendermint and I can make those changes if there is agreement. |
Sounds like we should revisit logs and "downgrade" some of that logs to |
I agree. We should revisit all logs and ensure that each and every of them matches their respective level as defined by RFC5424 (also known as the Syslog Protocol) - page 10. |
logs grow extremely fast |
That is a bug it seems. |
I tried to fiddle around with it and call I would suggest to SDK devs to re-evaluate this and adopt a more explicit and easier to understand flow such as the one used in Atlas. |
I couldn't agree more. Plus, we should start transitioning to config file-based binaries (when flags become numerous, UX could be impacted heavily). |
You mean a binary format for config file? That sounds as a bad idea. |
Sorry Robert, I didn't explain myself correctly. We used to support reading client configuration from file. We should reintroduce that feature, AFAIK users did use it quite a lot. |
I think at least seperate tendermint logging and cosmos logging into two different flags , so we can turn it on / off seperately |
Since most of the noisy and verbose logs (most of which are useless at the info level) come from Tendermint, this isn't a terrible idea. |
Yeah I agree |
Yes please! |
I've started a PR in Tendermint where we downgrade a bunch of logs to DEBUG. If you find any logs that you believe need to be downgraded or are outright superfluous and not needed, please mention them there so I can tackle them. |
Getting massive logs daily (e.g. 1GB) in new Compared old configuration vs new they both have identical loglevel set to: Also changing in the configuration loglevel seems to not affect the actual logging - the spam still going on, so you need to pass on the commandline to the gaia. |
Confirming these issues. Changing either of the below fields in the
|
I would consider closing this issue. Many of the logs have already been groomed and included in the latest Tendermint 0.34 release. |
Closing this as per @alexanderbez's suggestion. |
I think you're too fast to close this issue, even in the latest
in previous Please consider re-opening this issue. |
Yes, that's painful to me too. It's a tendermint issue I believe? @alexanderbez knows better
Set loglevel to warning and the redundant logs will go away. Else, mind giving me some examples, please? |
This doesn't help much, I still get errors like:
and logs are growing very fast. the main issue is with the new release that logs are growing much more comparing to the old one: #8132 (comment) |
this is encapsulated in #9034. Closing this issue |
@marbar3778 the issue I've reported in #8132 (comment) is still relevant for Logs are ugly and growing very fast. Still no option to disable coloring on human format. Thank you. |
Summary of Bug
There are too many logs by default.
Version
02fb3a3
Steps to Reproduce
See logs on a fresh chain after 3 blocks:
Click to expand
Proposals
The default log level was switched recently:
1. either switch back to the old log level (is that possible?)
2. walk through the code, and put some logs as debug instead of info.
For Admin Use
The text was updated successfully, but these errors were encountered: