Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Impove test coverage of x/evm/statedb package #876

Closed
yihuang opened this issue Jan 5, 2022 · 1 comment · Fixed by #888
Closed

Impove test coverage of x/evm/statedb package #876

yihuang opened this issue Jan 5, 2022 · 1 comment · Fixed by #888
Labels
C:x/evm EVM module Type: Tests issues and PR related to tests

Comments

@yihuang
Copy link
Contributor

yihuang commented Jan 5, 2022 •
edited
Loading

Proposal: Impove test coverage of x/evm/statedb package:

x/evm/statedb/access_list.go
x/evm/statedb/journal.go
x/evm/statedb/state_object.go
x/evm/statedb/statedb.go
x/evm/statedb/config.go
x/evm/statedb/interfaces.go

Current behavior: not good enough

Desired behavior: try to achieve 100% coverage

Use case: it's the core part of the logic, easier to test because it's in-memory now.
@yihuang yihuang mentioned this issue Jan 5, 2022
Merged
11 tasks
@yihuang
Copy link
Contributor Author

yihuang commented Jan 6, 2022

working on it.

@fedekunze fedekunze added C:x/evm EVM module Type: Tests issues and PR related to tests labels Jan 6, 2022
@yihuang yihuang mentioned this issue Jan 6, 2022
Merged
11 tasks
yihuang added a commit to yihuang/ethermint that referenced this issue Jan 6, 2022
@yihuang
Impove test coverage of x/evm/statedb package
3de7452 
Closes: evmos#876
- coverage: 99.3% of statements
fedekunze pushed a commit that referenced this issue Jan 6, 2022
@yihuang
evm: improve test coverage of statedb package (#888)
e6c9b77 
Closes: #876
- coverage: 99.3% of statements
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C:x/evm EVM module Type: Tests issues and PR related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Impove test coverage of x/evm/statedb package yihuang/ethermint
2 participants
@yihuang @fedekunze