-
Notifications
You must be signed in to change notification settings - Fork 562
feat!: Apply feemarket to native cosmos tx #1194
Conversation
d1e2c98
to
18a6c70
Compare
@yihuang can you fix the conflicts |
0a02832
to
0a7ab8b
Compare
6d7d6a5
to
5ff0552
Compare
43a89dd
to
f51f129
Compare
4a2539b
to
89e1a16
Compare
Codecov Report
@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
+ Coverage 51.92% 52.33% +0.41%
==========================================
Files 102 104 +2
Lines 9284 9387 +103
==========================================
+ Hits 4821 4913 +92
- Misses 4215 4225 +10
- Partials 248 249 +1
|
864bf78
to
088c630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good so I will approve it but I will open a discussion.
I would prefer sdk_tx.go
logic to be in the Feemarket module instead of the EVM module. I understand that it needs the LondonHardFork
param so it will be kind of tricky to have this in the FeeMarket so happy to leave it like this. I just think it will be the cleaner approach if there was a way to make it happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for the PR. How do you see wallets implementing the extension? If we don't use it by default most wallets won't use this logic. I'd change the default to be the fee market to cosmos txs and the extension for the old logic.
Also, this PR is missing unit tests
Soluton: - remove the positional height parameter, since there's a flag already. Update CHANGELOG.md
- add tx extension option for user to input tip price - apply feemarket's base fee to native tx comments and cleanup fallback to default sdk logic when london hardfork not enabled integration test cleanup feemarket query cli commands Update CHANGELOG.md update unit tests disable feemarket in simulation tests for now fix lint Update app/simulation_test.go fix python lint fix lint Update x/evm/types/extension_option.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> address review suggestions
30bd00a
to
f37399c
Compare
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. I did a minor refactor to make the code more maintainable. Great work!
Head branch was pushed to by a user without write access
the gofmt warning can't be reproduced locally, any ideas @facs95 ? |
Description
Apply feemarket to native cosmos tx
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)