Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix(rpc): estimate gas error response #1340

Merged
merged 5 commits into from
Sep 17, 2022
Merged

fix(rpc): estimate gas error response #1340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2470802
format error on EstimateGas rpc call
ramacarlucho Sep 14, 2022
0780086
changelog
ramacarlucho Sep 14, 2022
f71f1b7
Merge branch 'main' into rama/fix_estimate_gas_error
fedekunze Sep 16, 2022
6c1781e
Merge branch 'main' into rama/fix_estimate_gas_error
fedekunze Sep 17, 2022
e3692b2
Merge branch 'main' into rama/fix_estimate_gas_error
fedekunze Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

* (rpc) [#1179](https://github.com/evmos/ethermint/pull/1179) Fix gas used in traceTransaction response.
* (rpc) [#1284](https://github.com/evmos/ethermint/pull/1284) Fix internal trace response upon incomplete `eth_sendTransaction` call.
* (rpc) [#1340](https://github.com/evmos/ethermint/pull/1340) Fix error response when `eth_estimateGas` height provided is not found.

## [v0.19.2] - 2022-08-29

Expand Down
6 changes: 6 additions & 0 deletions rpc/backend/call_tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,12 @@ func (b *Backend) EstimateGas(args evmtypes.TransactionArgs, blockNrOptional *rp
GasCap: b.RPCGasCap(),
}

_, err = b.TendermintBlockByNumber(blockNr)
if err != nil {
// the error message imitates geth behavior
return 0, errors.New("header not found")
}

// From ContextWithHeight: if the provided height is 0,
// it will return an empty context and the gRPC query will use
// the latest block height for querying.
Expand Down
2 changes: 2 additions & 0 deletions tests/integration_tests/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,8 @@ def test_estimate_gas(ethermint, geth):
eth_rpc = ethermint.w3.provider
geth_rpc = geth.w3.provider
make_same_rpc_calls(eth_rpc, geth_rpc, "eth_estimateGas", [tx])
make_same_rpc_calls(eth_rpc, geth_rpc, "eth_estimateGas", [tx, "0x0"])
make_same_rpc_calls(eth_rpc, geth_rpc, "eth_estimateGas", [tx, "0x5000"])
make_same_rpc_calls(eth_rpc, geth_rpc, "eth_estimateGas", [{}])


Expand Down