fix(rpc): align fee history #1611

mmsqe · 2023-01-18T00:59:43Z

Closes: #1559

Description

eth_feeHistory returns less item in baseFeePerGas array
eth_feeHistory returns oldestBlock - 1 compare with eth
fix broken earliest input

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

codecov · 2023-01-18T10:13:02Z

Codecov Report

Merging #1611 (b2b58d6) into main (6505f6e) will decrease coverage by 0.03%.
The diff coverage is 73.68%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
- Coverage   68.35%   68.33%   -0.03%     
==========================================
  Files         110      110              
  Lines       10181    10184       +3     
==========================================
  Hits         6959     6959              
- Misses       2819     2821       +2     
- Partials      403      404       +1

Impacted Files	Coverage Δ
rpc/backend/utils.go	`43.50% <50.00%> (-0.43%)`	⬇️
rpc/backend/chain_info.go	`82.73% <84.61%> (-0.11%)`	⬇️

rpc/backend/utils.go

tests/integration_tests/test_fee_history.py

CHANGELOG.md

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>

rpc/backend/chain_info.go

 		blockNumber, err := b.BlockNumber()
 		if err != nil {
 			return nil, err
 		}
 		blockEnd = int64(blockNumber)
 	}

-	userBlockCountInt := int64(userBlockCount)
+	blocks := int64(userBlockCount)


MalteHerrmann · 2023-01-20T13:18:36Z

@Mergifyio backport release/v0.21.x

* update nix * add next fee in fee history * fix test * add change doc * height + 1 for next fee * cross check baseFeePerGas len * Update tests/integration_tests/test_fee_history.py Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * fix oldestBlock & align earliest input as eth * update doc * update nix * isort test_fee_history.py * fix test * align rpc res as eth * add cross check * add baseFeePerGas len check * add oldestBlock check Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 47fdfd3) # Conflicts: # CHANGELOG.md

mergify · 2023-01-20T13:19:18Z

backport release/v0.21.x

✅ Backports have been created

#1620 fix(rpc): align fee history (backport #1611) has been created for branch release/v0.21.x

* fix(rpc): align fee history (#1611) * update nix * add next fee in fee history * fix test * add change doc * height + 1 for next fee * cross check baseFeePerGas len * Update tests/integration_tests/test_fee_history.py Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * fix oldestBlock & align earliest input as eth * update doc * update nix * isort test_fee_history.py * fix test * align rpc res as eth * add cross check * add baseFeePerGas len check * add oldestBlock check Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 47fdfd3) # Conflicts: # CHANGELOG.md * address merge conflicts Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: MalteHerrmann <malte@evmos.org> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* release: v0.21.0-rc1 changelog (#1606) * changelog: added rc-1 changelog entry * fix: typo fix rc1 * fix(rpc): bind default json-rpc listen address to localhost (backport #1613) (#1621) * fix(rpc): bind default json-rpc listen address to localhost (#1613) * update nix * bind default json-rpc to 127.0.0.1 * add change doc * Update CHANGELOG.md Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 3587015) # Conflicts: # CHANGELOG.md * address merge conflicts Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: MalteHerrmann <malte@evmos.org> * fix(rpc): align fee history (backport #1611) (#1620) * fix(rpc): align fee history (#1611) * update nix * add next fee in fee history * fix test * add change doc * height + 1 for next fee * cross check baseFeePerGas len * Update tests/integration_tests/test_fee_history.py Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * fix oldestBlock & align earliest input as eth * update doc * update nix * isort test_fee_history.py * fix test * align rpc res as eth * add cross check * add baseFeePerGas len check * add oldestBlock check Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 47fdfd3) # Conflicts: # CHANGELOG.md * address merge conflicts Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: MalteHerrmann <malte@evmos.org> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * support customize db opener in `StartCmd` (backport #1615) (#1622) * support customize db opener in `StartCmd` (#1615) * support customize db opener in `StartCmd` * Update CHANGELOG.md * pass to dbOpener, so we can control different options through cli flags * add comments (cherry picked from commit f1337aa) # Conflicts: # CHANGELOG.md * conflicts Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * tests(evm): add benchmark tests setup for params (#1623) (#1627) * tests: add benchmark tests setup * fix: localized benchmark tests to keeper * update benchmark Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 9305788) Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> * refactor(params): store all params under one key in evm module (backport #1617) (#1626) * refactor(params): store all params under one key in evm module (#1617) * refactor(params): store all params under one key in evm module * refactor(params): add changelog entry * refactor(params): update based on review comments. Remove params getter functions * refactor(params): refactor params store key * refactor(params): remove unnecessary store keys * refactor(params): add paramSetPairs for backwards compatibility * Update CHANGELOG.md * refactor(params): add license to params_legacy file * Apply suggestions from code review * fix(evm): handle RC1 params during migration (#1624) * fix(evm): handle RC1 params during migration * migration * fix: test case updated for RC1 * v5 migration * tests * tests pt2 * comment * execute make proto-all Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: MalteHerrmann <malte@evmos.org> * Apply suggestions from code review * rm dup vars Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: MalteHerrmann <malte@evmos.org> (cherry picked from commit f07b14f) # Conflicts: # CHANGELOG.md * update changelog Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: MalteHerrmann <malte@evmos.org> * fix(evm): revert v4 migration changes (#1625) (#1628) * fix(evm): revert v4 migration changes * add check for chainID * fix: renamed vars to avoid duplicate proto * test * fix: set default extraEIPs to nil * fix: updated tests Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> (cherry picked from commit 9bfa1ff) Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * minor improvement to changelog (#1629) * adjust year to 2023 for v0.21.0-rc2 release (#1630) * Update CHANGELOG.md Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>

* update nix * add next fee in fee history * fix test * add change doc * height + 1 for next fee * cross check baseFeePerGas len * Update tests/integration_tests/test_fee_history.py Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * fix oldestBlock & align earliest input as eth * update doc * update nix * isort test_fee_history.py * fix test * align rpc res as eth * add cross check * add baseFeePerGas len check * add oldestBlock check Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* update nix * add next fee in fee history * fix test * add change doc * height + 1 for next fee * cross check baseFeePerGas len * Update tests/integration_tests/test_fee_history.py * fix oldestBlock & align earliest input as eth * update doc * update nix * isort test_fee_history.py * fix test * align rpc res as eth * add cross check * add baseFeePerGas len check * add oldestBlock check Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

mmsqe added 4 commits January 17, 2023 14:18

update nix

f4216ac

add next fee in fee history

34a416d

fix test

588e232

add change doc

29a1c3b

mmsqe marked this pull request as ready for review January 18, 2023 10:05

mmsqe requested a review from a team as a code owner January 18, 2023 10:05

mmsqe requested review from 0a1c and adisaran64 and removed request for a team January 18, 2023 10:05

mmsqe added 3 commits January 18, 2023 22:52

height + 1 for next fee

c8e1f60

cross check baseFeePerGas len

da0fe9e

Merge branch 'main' into align_fee_history

873169c

MalteHerrmann reviewed Jan 19, 2023

View reviewed changes

rpc/backend/utils.go Show resolved Hide resolved

tests/integration_tests/test_fee_history.py Outdated Show resolved Hide resolved

MalteHerrmann reviewed Jan 19, 2023

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

mmsqe and others added 5 commits January 19, 2023 20:30

Update tests/integration_tests/test_fee_history.py

e422b2a

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>

fix oldestBlock & align earliest input as eth

0d9d603

update doc

2c5898a

update nix

caf0060

Merge branch 'main' into align_fee_history

eac012a

github-advanced-security bot found potential problems Jan 19, 2023

View reviewed changes

mmsqe added 6 commits January 19, 2023 20:40

isort test_fee_history.py

613ec70

fix test

23fed3a

align rpc res as eth

7eb7aa3

add cross check

e062361

add baseFeePerGas len check

3f89b22

add oldestBlock check

e693133

fedekunze approved these changes Jan 20, 2023

View reviewed changes

Merge branch 'main' into align_fee_history

b2b58d6

fedekunze merged commit 47fdfd3 into evmos:main Jan 20, 2023

mergify bot mentioned this pull request Jan 20, 2023

fix(rpc): align fee history (backport #1611) #1620

Merged

This was referenced Jan 24, 2023

chore: merge release/v11.0.x back into main evmos/evmos#1273

Closed

chore: sync main with v0.21.x branch #1636

Merged

mmsqe mentioned this pull request Mar 14, 2023

fix(rpc): align fee history (backport: #1611) crypto-org-chain/ethermint#223

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(rpc): align fee history #1611

fix(rpc): align fee history #1611

mmsqe commented Jan 18, 2023 •

edited

Loading

codecov bot commented Jan 18, 2023 •

edited

Loading

MalteHerrmann commented Jan 20, 2023

mergify bot commented Jan 20, 2023

fix(rpc): align fee history #1611

fix(rpc): align fee history #1611

Conversation

mmsqe commented Jan 18, 2023 • edited Loading

Description

codecov bot commented Jan 18, 2023 • edited Loading

Codecov Report

MalteHerrmann commented Jan 20, 2023

mergify bot commented Jan 20, 2023

✅ Backports have been created

mmsqe commented Jan 18, 2023 •

edited

Loading

codecov bot commented Jan 18, 2023 •

edited

Loading