This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see #263, that should fix the issue |
I have checked on main (including #263) but the issue is still there. It is working if I always use ctx's height = height +1 . Not sure why it is happening. I will need to investigate further |
thomas-nguy
force-pushed
the
thomas/248-getlogs
branch
from
July 12, 2021 12:30
f6368a7
to
be47692
Compare
thomas-nguy
commented
Jul 13, 2021
fedekunze
reviewed
Jul 13, 2021
thomas-nguy
commented
Jul 13, 2021
thomas-nguy
force-pushed
the
thomas/248-getlogs
branch
from
July 13, 2021 08:55
fff150a
to
e59aeae
Compare
fedekunze
reviewed
Jul 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few requests for comments. Make sure you pull the latest changes from main
thomas-nguy
force-pushed
the
thomas/248-getlogs
branch
from
July 13, 2021 14:11
4db3a18
to
f612c5e
Compare
fedekunze
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, can you add a bugfix changelog entry?
sure, README updated |
thomas-nguy
force-pushed
the
thomas/248-getlogs
branch
from
July 14, 2021 09:31
bdddc3c
to
7716303
Compare
Codecov Report
@@ Coverage Diff @@
## main #258 +/- ##
==========================================
- Coverage 47.55% 47.54% -0.02%
==========================================
Files 45 45
Lines 3135 3136 +1
==========================================
Hits 1491 1491
- Misses 1569 1570 +1
Partials 75 75
|
fedekunze
reviewed
Jul 14, 2021
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #248
Description
When blockbloom is nil and empty it is currently returning an error. We should return an empty bloom instead to avoid breaking other functionnalities.
Note that I have notice a weird behavior with the context (which return a blockboom at currentheight-1 when context is set at current height but it cannot be found is context is set at current height -1
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)