Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

evm: use block proposer address for COINBASE opcode #291

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Jul 14, 2021

noticed that the address was empty for the COINBASE opcode

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #291 (702cd4a) into main (5e87661) will increase coverage by 0.05%.
The diff coverage is 52.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   47.54%   47.60%   +0.05%     
==========================================
  Files          45       45              
  Lines        3136     3151      +15     
==========================================
+ Hits         1491     1500       +9     
- Misses       1570     1576       +6     
  Partials       75       75              
Impacted Files Coverage Δ
x/evm/keeper/grpc_query.go 74.03% <0.00%> (-1.25%) ⬇️
x/evm/keeper/state_transition.go 6.33% <64.28%> (+6.33%) ⬆️
app/ante/eth.go 90.04% <100.00%> (ø)

@fedekunze fedekunze marked this pull request as ready for review July 14, 2021 20:36
@fedekunze fedekunze enabled auto-merge (squash) July 14, 2021 20:37
@fedekunze fedekunze merged commit 9d1ce30 into main Jul 14, 2021
@fedekunze fedekunze deleted the fedekunze/coinbase branch July 14, 2021 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant