Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

rpc: fix Bloom filter response #321

Merged
merged 3 commits into from
Jul 20, 2021

Conversation

thomas-nguy
Copy link
Contributor

@thomas-nguy thomas-nguy commented Jul 19, 2021

Closes: #277

Description

Fix bloom filter query request.

Height needs to be passed explicitly in the grpc query because tendermint will always uses the current context header.
So it wont be possible to extract the queried 'height' from there


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #321 (3d09c8f) into main (bb6622b) will decrease coverage by 0.10%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   47.48%   47.38%   -0.11%     
==========================================
  Files          46       46              
  Lines        4601     4611      +10     
==========================================
  Hits         2185     2185              
- Misses       2338     2348      +10     
  Partials       78       78              
Impacted Files Coverage Δ
x/evm/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/evm/keeper/grpc_query.go 56.48% <100.00%> (ø)

@fedekunze fedekunze changed the title fix bloomfilter in rpc response rpc: fix Bloom filter response Jul 19, 2021
@thomas-nguy thomas-nguy force-pushed the thomas/277-fix-bloomfilter-request branch from fad8391 to acf1845 Compare July 20, 2021 00:26
@fedekunze
Copy link
Contributor

@thomas-nguy can you fix the conflicts?

@fedekunze fedekunze enabled auto-merge (squash) July 20, 2021 12:39
@thomas-nguy thomas-nguy force-pushed the thomas/277-fix-bloomfilter-request branch from acf1845 to 3d09c8f Compare July 20, 2021 15:06
@fedekunze fedekunze merged commit 0276f34 into evmos:main Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockBloom in block and header always returns empty
2 participants