-
Notifications
You must be signed in to change notification settings - Fork 562
Remove tx logs and block bloom from chain state #556
Conversation
Visit https://dashboard.github.orijtech.com?back=0&pr=556&remote=true&repo=yihuang%2Fethermint to see benchmark details. |
4fe3bbf
to
5f33a64
Compare
Codecov Report
@@ Coverage Diff @@
## main #556 +/- ##
==========================================
- Coverage 53.78% 53.38% -0.41%
==========================================
Files 64 64
Lines 5282 5127 -155
==========================================
- Hits 2841 2737 -104
+ Misses 2307 2263 -44
+ Partials 134 127 -7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. I would also add documentation on the JSON-RPC to turn on event indexing so that people don't run into the issue of not finding the bloom filter or logs.
This change is state machine braking so we also need to add an entry on the CHANGELOG
d56f297
to
005aad5
Compare
In this PR, we actually only used the
changelog added. |
Thanks @yihuang feel free to fix the linter with |
Closes #452 fix unit tests changelog and fix lint fix unit test Update ethereum/rpc/backend/backend.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Update ethereum/rpc/backend/utils.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> changelog
1d4d22d
to
76de16a
Compare
Closes #452
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)