-
Notifications
You must be signed in to change notification settings - Fork 562
Conversation
4eb31ad
to
3ef628c
Compare
Codecov Report
@@ Coverage Diff @@
## main #649 +/- ##
==========================================
+ Coverage 56.91% 56.98% +0.06%
==========================================
Files 63 63
Lines 5557 5568 +11
==========================================
+ Hits 3163 3173 +10
- Misses 2231 2234 +3
+ Partials 163 161 -2
|
a0a9e41
to
2a623f8
Compare
6f33406
to
987ef97
Compare
@JayT106 is this still WIP? if not, can you update the title? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, minor comments
expectPass: false, | ||
dynamicTxFee: true, | ||
}, | ||
// TODO: is this case valid? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because in this case, the effectiveTip
will be 0
, So there is no fee that has been deducting in authante, which causes the error returns. Is it an expecting behavior?
5213b07
to
a1ce914
Compare
@fedekunze There is a non-deterministic test case |
Closes: #622
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)