This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 562
Problem: empty topics shouldn't be encoded as nil #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: evmos#839 Solution: - encode it as empty array
yihuang
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
December 14, 2021 07:07
11 tasks
yihuang
added a commit
to yihuang/ethermint
that referenced
this pull request
Dec 14, 2021
yihuang
added a commit
to crypto-org-chain/ethermint
that referenced
this pull request
Dec 14, 2021
Codecov Report
@@ Coverage Diff @@
## main #840 +/- ##
=======================================
Coverage 57.31% 57.31%
=======================================
Files 72 72
Lines 5984 5984
=======================================
Hits 3430 3430
Misses 2357 2357
Partials 197 197
|
13 tasks
fedekunze
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, can you add a changelog entry?
done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #839
Description
Solution:
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)