This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 562
fix: set correct nonce in EthCall/EstimateGas #871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
January 4, 2022 08:27
fedekunze
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, can you add a test to ensure this doesn't break again? 🙏
CHANGELOG.md
Outdated
@@ -66,6 +66,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
* (evm) [tharsis#838](https://github.com/tharsis/ethermint/pull/838) Fix splitting of trace.Memory into 32 chunks. | |||
* (rpc) [tharsis#860](https://github.com/tharsis/ethermint/pull/860) Fix `eth_getLogs` when specify blockHash without address/topics, and limit the response size. | |||
* (rpc) [tharsis#865](https://github.com/tharsis/ethermint/pull/865) Fix RPC Filter parameters being ignored | |||
* (evm) [tharsis#]() Set correct nonce in `EthCall` and `EstimateGas` grpc query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing link 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Codecov Report
@@ Coverage Diff @@
## main #871 +/- ##
==========================================
+ Coverage 57.18% 57.40% +0.21%
==========================================
Files 74 74
Lines 6141 6148 +7
==========================================
+ Hits 3512 3529 +17
+ Misses 2423 2408 -15
- Partials 206 211 +5
|
13 tasks
yihuang
commented
Jan 4, 2022
unit test added, I checked that the test fail on main branch. |
prolenking
pushed a commit
to bianjieai/ethermint
that referenced
this pull request
Jun 15, 2022
aofengli
pushed a commit
to bianjieai/ethermint
that referenced
this pull request
Jun 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #870
Description
for contract creation tx, the executing msg must contain the correct nonce value, because
ApplyMessage
will reset sender's nonce to that first.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)