Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set x/staking min-commission #1054

Closed
wants to merge 3 commits into from

Conversation

giansalex
Copy link
Contributor

@giansalex giansalex commented Nov 5, 2022

Description

  • Set validator min-commission rate
  • Remove commision ante

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@giansalex giansalex requested a review from a team as a code owner November 5, 2022 16:53
@giansalex giansalex requested review from 0a1c and MalteHerrmann and removed request for a team November 5, 2022 16:53
@fedekunze fedekunze requested a review from danburck November 6, 2022 07:58
@fedekunze
Copy link
Contributor

@danburck looks like we need to update the params

@giansalex giansalex changed the title Set x/staking min-commision Set x/staking min-commission Nov 6, 2022
@fedekunze fedekunze marked this pull request as draft November 7, 2022 10:32
@fedekunze
Copy link
Contributor

thanks @giansalex! I created a new PR with a few additional changes #1057

@fedekunze fedekunze closed this Nov 7, 2022
@giansalex giansalex deleted the sdk46-min-commision branch November 7, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants