Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(revenue): Deprecate x/params usage in x/revenue #1129

Merged
merged 17 commits into from
Dec 15, 2022

Conversation

Vvaradinov
Copy link
Contributor

@Vvaradinov Vvaradinov commented Dec 1, 2022

Deprecates the now legacy Cosmos SDK x/params usage in x/revenue module. For more info regarding changes check out evmos/ethermint#1472

Description

Closes: ENG-1119


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@Vvaradinov Vvaradinov requested review from ramacarlucho, hanchon and a team as code owners December 1, 2022 12:55
@linear
Copy link

linear bot commented Dec 1, 2022

ENG-1119 Deprecate Cosmos x/params logic from revenue module

In relation to ENG-965

  • Create new proto message
  • Create new store migration
  • Update app.go and module.go
  • Update / Create unit tests
  • Create new getters and setter function for params

@github-actions github-actions bot added the proto label Dec 1, 2022
x/revenue/keeper/msg_server.go Outdated Show resolved Hide resolved
x/revenue/keeper/params.go Outdated Show resolved Hide resolved
x/revenue/keeper/params.go Outdated Show resolved Hide resolved
x/revenue/migrations/v2/migrate.go Outdated Show resolved Hide resolved
x/revenue/migrations/v2/migrate_test.go Outdated Show resolved Hide resolved
Vvaradinov and others added 4 commits December 9, 2022 17:44
Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>
# Conflicts:
#	CHANGELOG.md
#	x/revenue/types/interfaces.go
Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Vvaradinov!! Left a few comments and questions

proto/evmos/revenue/v1/tx.proto Outdated Show resolved Hide resolved
x/revenue/genesis.go Outdated Show resolved Hide resolved
x/revenue/genesis.go Outdated Show resolved Hide resolved
proto/evmos/revenue/v1/tx.proto Outdated Show resolved Hide resolved
x/revenue/module.go Outdated Show resolved Hide resolved
x/revenue/module.go Outdated Show resolved Hide resolved
x/revenue/types/interfaces.go Outdated Show resolved Hide resolved
x/revenue/types/msg.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #1129 (d03ee4d) into main (1d7e0b0) will decrease coverage by 0.34%.
The diff coverage is 42.25%.

❗ Current head d03ee4d differs from pull request most recent head ad8cbe5. Consider uploading reports for the commit ad8cbe5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
- Coverage   78.39%   78.05%   -0.35%     
==========================================
  Files         131      132       +1     
  Lines        7805     7818      +13     
==========================================
- Hits         6119     6102      -17     
- Misses       1533     1560      +27     
- Partials      153      156       +3     
Impacted Files Coverage Δ
x/revenue/handler.go 0.00% <0.00%> (ø)
x/revenue/keeper/msg_server.go 95.67% <0.00%> (-4.33%) ⬇️
x/revenue/types/msg.go 86.02% <0.00%> (-13.98%) ⬇️
x/revenue/types/params.go 93.75% <ø> (-0.90%) ⬇️
x/revenue/genesis.go 33.33% <33.33%> (-6.67%) ⬇️
x/revenue/keeper/params.go 64.70% <60.00%> (-35.30%) ⬇️
x/revenue/migrations/v2/migrate.go 62.50% <62.50%> (ø)
x/revenue/keeper/migrations.go 71.42% <71.42%> (ø)
app/app.go 81.53% <100.00%> (-0.23%) ⬇️
x/revenue/keeper/keeper.go 100.00% <100.00%> (ø)
... and 4 more

@Vvaradinov Vvaradinov merged commit 37e6402 into main Dec 15, 2022
@Vvaradinov Vvaradinov deleted the Vvaradinov/revenue-params-refactor branch December 15, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants