-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(revenue): Deprecate x/params usage in x/revenue #1129
Conversation
…cross the revenue module
ENG-1119 Deprecate Cosmos x/params logic from revenue module
In relation to ENG-965
|
Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>
# Conflicts: # CHANGELOG.md # x/revenue/types/interfaces.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @Vvaradinov!! Left a few comments and questions
Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
- Coverage 78.39% 78.05% -0.35%
==========================================
Files 131 132 +1
Lines 7805 7818 +13
==========================================
- Hits 6119 6102 -17
- Misses 1533 1560 +27
- Partials 153 156 +3
|
Deprecates the now legacy Cosmos SDK x/params usage in x/revenue module. For more info regarding changes check out evmos/ethermint#1472
Description
Closes: ENG-1119
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
Code maintenance:
I have...
godoc
and code comments.docs/
) or specification (x/<module>/spec/
)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...