imp(tests): add utility to check balances in tests #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalteHerrmann
requested review from
facs95 and
0xstepit
and removed request for
a team
ramacarlucho
approved these changes
Jan 24, 2024
5 tasks
hanchon
approved these changes
Jan 24, 2024
facs95
reviewed
Jan 24, 2024
| } | ||
|
|
||
| for _, tc := range testcases { | ||
| tc := tc |
There was a problem hiding this comment.
This is a super weird pattern in Go I've noticed 👀 in the past we've had problems where the tc fields were only using values of the last testcase - this solves it. It's very weird though and didn't occur on all tests though .. you'll also find this pattern everywhere in the Cosmos SDK repo for example and also we have it in our codebase a lot
| ) | ||
|
|
||
| func TestCheckBalances(t *testing.T) { | ||
| testDenom := "atest" |
There was a problem hiding this comment.
just to check it also works not only for the basic Evmos denom 👀 not 100% necessary but also doesn't harm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a helper function to more easily check expected balances during tests.