refactor: pick out Stack changes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -871,9 +871,9 @@ | |||
| ) | |||
| *pc += 1 | |||
| if *pc < codeLen { | |||
| scope.Stack.push(integer.SetUint64(uint64(scope.Contract.Code[*pc]))) | |||
| scope.Stack.Push(integer.SetUint64(uint64(scope.Contract.Code[*pc]))) | |||
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| return nil, nil | ||
| } | ||
|
|
||
| func opMsize(pc *uint64, interpreter *EVMInterpreter, scope *ScopeContext) ([]byte, error) { | ||
| scope.Stack.push(new(uint256.Int).SetUint64(uint64(scope.Memory.Len()))) | ||
| scope.Stack.Push(new(uint256.Int).SetUint64(uint64(scope.Memory.Len()))) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| @@ -316,7 +316,7 @@ | |||
| } | |||
|
|
|||
| func gasExpEIP158(evm *EVM, contract *Contract, stack *Stack, mem *Memory, memorySize uint64) (uint64, error) { | |||
| expByteLen := uint64((stack.data[stack.len()-2].BitLen() + 7) / 8) | |||
| expByteLen := uint64((stack.Data[stack.Len()-2].BitLen() + 7) / 8) | |||
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| @@ -303,7 +303,7 @@ | |||
| } | |||
|
|
|||
| func gasExpFrontier(evm *EVM, contract *Contract, stack *Stack, mem *Memory, memorySize uint64) (uint64, error) { | |||
| expByteLen := uint64((stack.data[stack.len()-2].BitLen() + 7) / 8) | |||
| expByteLen := uint64((stack.Data[stack.Len()-2].BitLen() + 7) / 8) | |||
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
fedekunze
approved these changes
Jan 16, 2023
|
@Mergifyio backport release/1.10 |
mergify bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
(cherry picked from commit 01221e9) # Conflicts: # CHANGELOG.md # core/vm/eips.go # core/vm/instructions.go # core/vm/instructions_test.go # eth/tracers/native/call.go
✅ Backports have been created
|
facs95
added a commit
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the default
vm.Stackand it's usage across the codebase.