Fix an issue with perpetually-running timer tests that manifests when another test attempts to use the event loop #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't a problem before, but the ticker is never stopped and so the event loop may keep running if it hasn't been explicitly stopped by the other test. The timer API definitely needs some work, but for now this band-aid should help a little bit.
rdw-software
force-pushed
the
fix-timer-tests
branch
from
94885ec
to
18a03db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't a problem before, but the ticker is never stopped and so the event loop may keep running if it hasn't been explicitly stopped by the other test. The timer API definitely needs some work, but for now this band-aid should help a little bit.
That's why the CI gets stuck on #533 - the new test expects the event loop to fall through, which it can't (due to the tickers).