Deleting files on up file sync

[EvanK]

It appears that, on sync from remote to local, we are removing any destination files that don't exist on source.

However, on sync from local to remote, we are not.

/cc @ericrasch

[EvanK]

As this could potentially break sites that rely on preserving remote symlinks, it should be merged and released with care.

I don't recall why this behavior was different for up than down, but I checked and Evolution does not have this issue.

Pinging @ericclemmons to see if it rings any bells for him

[ericrasch]

For background, we're needing this delete/sync capability in order to remove files in folders that aren't committed to repos, namely the /wp-content/uploads/ folder where exploit/hack files are being dropped-in and need removal.

[ericclemmons]

The original logic was:

• Remote will always be ahead of master because of content, uploaded images, and plugins modifying the file system. Therefore, when syncing down, if a file is missing on remote, it's best to know reflect that within the repo since this is a significant difference.
• Conversely, local wouldn't delete any remote files because users & plugins are modifying the file system beyond what's in master. Remember that /wp-content/uploads is normally not committed to the repo for size reasons and that it's considered a "DB".

I agree with @ericrasch that there needs to be a way to have a "clean slate", but I'm not 100% sure what that would be.

Each deployment technically starts "fresh" with a new git clone, but the shared_folders, not being versioned, remain between deployments.

I honestly don't know what the best solution is. We trust wp-content/uploads the same as we trust the MySQL DB: any cleanup is largely manual because it's expected to be pristine.

Any ideas?

[ericrasch]

What about keeping everything as-is, so genesis:up:files is still safe-guarded, but adding another command which allows for the clean slate. How about something like genesis:up:mirror which would allow for the removal/deletion of files on the remote site?

[ericclemmons]

👍 Great suggestion! genesis:up:mirror seems very clear to me. I almost considered genesis:up:files --force, but...switches suck :)

[ericrasch]

Thumbs down?

[ericclemmons]

Not according to this screen shot after I edited the typo :)

[EvanK]

Implemented!

[EvanK]

@ericrasch Fixed copy-links bug as of v0.2.60

[ericrasch]

Thanks, @EvanK, works great!