Varnish/Apache issues #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -300,7 +300,6 @@ sudo /Library/StartupItems/VirtualBox/VirtualBox restart | |||
|
|
|||
| ## Changelog | |||
|
|
|||
| - v0.2.39 – Revert v0.2.37 (aa9e83f) | |||
There was a problem hiding this comment.
We'll need to keep this line because the tag will still physically exist.
There was a problem hiding this comment.
Oops, didn't realize that came along in the revert 
|
Also simplified the regex we're using to match wp cookies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reintroduces fixes for Varnish wordpress login/admin, fixes cookie issues from #84, and (hopefully) addresses the apache perf issue in #89
With regard to apache performance, we're hardcoding a minimum
MaxClientsvalue of 5 which may cause lower end servers to use swap and thrash themselves a bit under heavy load. This is a tradeoff, since it may be better than limiting them to handling only 1 or 2 concurrent requests.