Add config.quiet_assets_paths option to allow suppressing additional pat... #34
Conversation
…paths from the log output.
| @@ -26,6 +26,11 @@ place the following in your `config/application.rb` file: | |||
|
|
|||
| config.quiet_assets = false | |||
|
|
|||
| If you need to supress output for other paths you can do so by specifying: | |||
|
|
|||
| config.quiet_assets_paths << '/silent/' | |||
There was a problem hiding this comment.
Let's use another name for this option. I think it doesn't mean quiet assets paths anymore. Something like suppressed_paths or any other you can think of.
There was a problem hiding this comment.
My thinking was that it should be at least prefixed with "quiet_assets" to namespace it (sort of) to this gem. quiet_assets_suppressed_paths would work though. Thoughts?
There was a problem hiding this comment.
Well, people say we could use such thing as config.quiet_assets.enabled = true and config.quiet_assets.paths. WDYT about this?
There was a problem hiding this comment.
Reasonable, but seems like over kill too. Unless you've had people ask for the enabled option...
There was a problem hiding this comment.
Sorry I'm not following about the last point..
There was a problem hiding this comment.
Just saying I don't see the point in adding a "enabled" flag since people can just remove the gem if they don't want it. Feels like an option no one will ever use to me.
There was a problem hiding this comment.
Oh got it, agree. Let's leave just path then.
There was a problem hiding this comment.
Can this get merged in?
|
All the rest looks good to me 👍 |
Add config.quiet_assets_paths option to allow suppressing additional pat...
|
I'm not that fast :) Thanks again! |
|
Is this released yet? Doesn't seem like it |
|
Not yet. I have a plan to change the way we currently make it working on another, and then I'll release. |
|
Any chance for a gem release? |
...hs from the log output.
Same code as #30, but rebased off master.