fix after review

Signed-off-by: Lukas Hybner <git@hybner.net>
evryfs · Oct 19, 2021 · 210c537 · 210c537
1 parent 1ec05a9
commit 210c537
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/controllers/githubactionrunner_controller.go b/controllers/githubactionrunner_controller.go
@@ -364,8 +364,8 @@ func (r *GithubActionRunnerReconciler) handleFinalization(ctx context.Context, c
 		if err := r.unregisterRunner(ctx, cr, item); err != nil {
 			return err
 		}
-		if item.pod.Status.Phase == corev1.PodSucceeded {
-			logr.FromContext(ctx).Info("Deleting pod " + item.pod.Name)
+		if isCompleted(&item.pod) {
+			logr.FromContext(ctx).Info("Deleting succeeded pod", "podname", item.pod.Name)
 			err := r.DeleteResourceIfExists(ctx, &item.pod)
 			if err != nil {
 				return err