Dialyzer #241
Merged
Dialyzer #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following Dialyzer errors show up in Elixir 1.16, which then result in “has no local return” Dialyzer errors in clients of this library. This PR resolves them in a backwards compatible way.
```
lib/ex_aws/s3/upload.ex:70: Function stream_file/1 has no local return
lib/ex_aws/s3/upload.ex:70: Function stream_file/2 has no local return
lib/ex_aws/s3/upload.ex:71: The call 'Elixir.File':'stream!'(_path@1::any(),[],any()) breaks the contract ('Elixir.Path':t(),'line' | pos_integer(),[stream_mode()]) -> 'Elixir.File.Stream':t()
```
ref: elixir-lang/elixir#13212
|
Replaces #239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks for #239