Programmatically create permanent session #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ily called from outside
jmilkiewicz
force-pushed
the
issue-744
branch
from
4b925c1 to
31bd46a
Compare
server/src/main/java/com/exacaster/lighter/application/sessions/SessionService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/exacaster/lighter/rest/PermanentSessionController.java
Outdated
Show resolved
Hide resolved
jmilkiewicz
commented
Nov 20, 2023
server/src/main/java/com/exacaster/lighter/application/sessions/SessionService.java
Outdated
Show resolved
Hide resolved
jmilkiewicz
changed the title
|
I consider it is mostly done. |
server/src/main/java/com/exacaster/lighter/application/sessions/SessionHandler.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/exacaster/lighter/application/sessions/SessionService.java
Outdated
Show resolved
Hide resolved
server/src/test/groovy/com/exacaster/lighter/storage/jdbc/JdbcApplicationStorageTest.groovy
Outdated
Show resolved
Hide resolved
|
I've left some minor comments, other than that - nice job! |
fixed comments |
pdambrauskas
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My draft implementation in which we can potentially support creating permanent session via REST API and YAML file.
In case of conflict what we have in DB wins.