Skip to content

Commit

Permalink
fix: remove eventNs for image & scroll fix image ready event
Browse files Browse the repository at this point in the history
  • Loading branch information
ala-n committed Jan 22, 2021
1 parent c058400 commit 2f3382f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
4 changes: 1 addition & 3 deletions src/modules/esl-image/core/esl-image.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ const isLoadState = (state: string): state is LoadState => ['error', 'loaded', '
@ExportNs('Image')
export class ESLImage extends ESLBaseElement {
public static is = 'esl-image';
// Should not have own namespace for events to be native image compatible
public static eventNs = '';

// Default container class value
public static DEFAULT_CONTAINER_CLS = 'img-container-loaded';
Expand Down Expand Up @@ -282,7 +280,7 @@ export class ESLImage extends ESLBaseElement {
this.toggleAttribute('error', !successful);
this.toggleAttribute('ready', true);
this.$$fire(successful ? 'loaded' : 'error', {bubbles: false});
this.$$fireNs('ready', {bubbles: false});
this.$$fire('ready', {bubbles: false});
}

public updateContainerClasses() {
Expand Down
1 change: 0 additions & 1 deletion src/modules/esl-scrollbar/core/esl-scrollbar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {TraversingQuery} from '../../esl-traversing-query/core';
@ExportNs('Scrollbar')
export class ESLScrollbar extends ESLBaseElement {
public static is = 'esl-scrollbar';
public static eventNs = 'esl:scrollbar';

@boolAttr() public horizontal: boolean;

Expand Down

0 comments on commit 2f3382f

Please sign in to comment.