refactor: Drop Edge old versions (<14) support

Description: Remove the medium version of the polyfill for ESL UI site renderer Drop support for Edge old versions and ES6 polyfils BREAKING CHANGES: ESL UI site renderer and ESL polyfills no longer support Edge old versions and ES6 polyfils.
exadel-inc · Mar 17, 2023 · b577fd1 · b577fd1
1 parent 6d376ee
commit b577fd1
Show file tree

Hide file tree

Showing 13 changed files with 9 additions and 172 deletions.
diff --git a/docs/BROWSER_SUPPORT.md b/docs/BROWSER_SUPPORT.md
@@ -5,6 +5,12 @@
 Exadel Smart Library does not have dependencies but uses the following list of native browser features:
 
 - ECMAScript 6 features
+    - [Array.from](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from) (no Iterable Objects support required)
+    - [Array.prototype.find](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find)
+    - [Array.prototype.findIndex](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/findIndex)
+    - [Array.prototype.include](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes)
+    - [Object.is](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is)
+    - [Object.assign](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign) (accurate polyfill required)
     - [ES6 Promise](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise)
 - Web API
     - [Event](https://developer.mozilla.org/en-US/docs/Web/API/Event) constructor + `preventDefault` polyfill
@@ -20,13 +26,6 @@ Exadel Smart Library does not have dependencies but uses the following list of n
 
 All of them are fully supported by modern browsers such as Chrome, Firefox, Safari or Edge (>43).
 
-In order to make ESL work in older browsers, you can use a "light" polyfills list of IntersectionObserver, ResizeObserver and Custom Elements (for older versions of Edge and Safari).
+In order to make ESL work in older browsers, you can use a "light" polyfills list (for older versions Safari).
 
 See more details on what polyfill approach might look like in the demo pages source code.
-
-Also, ESL has built-in polyfills for some of DOM and ES6 features. They are available under [polyfills](../src/polyfills) directory:
-  - ECMA Script 5: output shim (`HTMLElement` constructor call) - [es5-target-shim.ts](../src/polyfills/es5-target-shim.ts)
-  - ECMA Script 6: DOM - [polyfills.es6.ts](../src/polyfills/polyfills.es6.ts)
-    - `Node.isConnected` 
-    - `KeyboardKey.prototype.key` 
-    - `Element.prototype.toggleAttribute` 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -97,7 +97,6 @@
     "@types/smoothscroll-polyfill": "^0.3.1",
     "@typescript-eslint/eslint-plugin": "^5.55.0",
     "@typescript-eslint/parser": "^5.55.0",
-    "@webcomponents/custom-elements": "1.5.1",
     "chokidar-cli": "^3.0.0",
     "clean-css-cli": "^5.6.2",
     "concurrently": "^7.6.0",
@@ -110,7 +109,6 @@
     "foreach-cli": "^1.8.1",
     "html-minifier": "^4.0.0",
     "husky": "^8.0.3",
-    "intersection-observer": "^0.12.2",
     "jest": "^29.5.0",
     "jest-environment-jsdom": "^29.5.0",
     "js-yaml": "^4.1.0",

diff --git a/pages/src/localdev.ts b/pages/src/localdev.ts
@@ -1,7 +1,5 @@
 // Support for ES5 bundle target
 import '../../src/polyfills/es5-target-shim';
-// Builtin polyfills
-import '../../src/polyfills/polyfills.es6';
 // Validate environment
 import '../../src/polyfills/polyfills.validate';
 

diff --git a/pages/src/polyfill-light.ts b/pages/src/polyfill-light.ts
@@ -1,9 +1,4 @@
-/**
- * Target: Edge, Safari 9
- */
-import '../../src/polyfills/polyfills.es6';
-
-// IE, Safari <13.3
+// Safari <13.3
 import {ResizeObserver} from '@juggle/resize-observer';
 window.ResizeObserver = window.ResizeObserver || ResizeObserver;
 

diff --git a/pages/src/polyfill-medium.ts b/pages/src/polyfill-medium.ts
diff --git a/pages/views/_includes/polyfill.njk b/pages/views/_includes/polyfill.njk
@@ -1,9 +1,7 @@
 <script>
   (function () {
     var version = '';
-    if (!('getRootNode' in Element.prototype) || !window.customElements) {
-      version = 'medium';
-    } else if (!window.scrollBy || !window.IntersectionObserver || !window.ResizeObserver || !window.ResizeObserver) {
+    if (!window.scrollBy || !window.ResizeObserver) {
       version = 'light';
     }
     (version) && document.write('<script type="text/javascript" src="{{ '/bundles/polyfill-' | url }}' + version + '.js"><\/script>');

diff --git a/pages/webpack.config.js b/pages/webpack.config.js
@@ -5,7 +5,6 @@ module.exports = {
   devtool: 'source-map',
   entry: {
     'localdev': './src/localdev.ts',
-    'polyfill-medium': './src/polyfill-medium.ts',
     'polyfill-light': './src/polyfill-light.ts'
   },
   resolve: {

diff --git a/src/polyfills/list/dom.element.toggleAttribute.ts b/src/polyfills/list/dom.element.toggleAttribute.ts
diff --git a/src/polyfills/list/dom.event.keyboard.ts b/src/polyfills/list/dom.event.keyboard.ts
diff --git a/src/polyfills/list/dom.keyboard.key.ts b/src/polyfills/list/dom.keyboard.key.ts
diff --git a/src/polyfills/list/dom.node.isConnected.ts b/src/polyfills/list/dom.node.isConnected.ts
diff --git a/src/polyfills/polyfills.es6.ts b/src/polyfills/polyfills.es6.ts