fix(esl-trigger): default target for esl-trigger is not logically c…

…orrect and obvious BREAKING CHANGE: `esl-trigger` does not have target defined to `::next` by default
exadel-inc · Dec 15, 2023 · db4ffb8 · db4ffb8
1 parent 3af3c8c
commit db4ffb8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/modules/esl-trigger/README.md b/src/modules/esl-trigger/README.md
@@ -16,7 +16,7 @@ Authors: *Alexey Stsefanovich (ala'n)*, *Julia Murashko*.
 
 - `active-class-target` - target element ESLTraversingQuery selector to set `active-class`
 
-- `target` - target Toggleable ESLTraversingQuery selector (`next` by default)
+- `target` - target Toggleable ESLTraversingQuery selector
 
 - `track-click` - [MediaQuery](../esl-media-query/README.md) to define allowed to track click event media. (Default: `all`)
 

diff --git a/src/modules/esl-trigger/core/esl-trigger.ts b/src/modules/esl-trigger/core/esl-trigger.ts
@@ -35,8 +35,8 @@ export class ESLTrigger extends ESLBaseElement {
   /** Selector for ignored inner elements */
   @attr({defaultValue: 'a[href]'}) public ignore: string;
 
-  /** Target Toggleable {@link ESLTraversingQuery} selector. `::next` by default */
-  @attr({defaultValue: '::next'}) public target: string;
+  /** Target Toggleable {@link ESLTraversingQuery} selector */
+  @attr({defaultValue: ''}) public target: string;
   /** Action to pass to the Toggleable. Supports `show`, `hide` and `toggle` values. `toggle` by default */
   @attr({defaultValue: 'toggle'}) public mode: string;