Skip to content

Commit

Permalink
refactor: exclude duplicated exports of esl-utils/decorators
Browse files Browse the repository at this point in the history
BREAKING CHANGE: `prop`, `attr`, `boolAttr`, `jsonAttr`, `listen` no longer available in `esl-base-element` and `esl-mixin-element` exports
  • Loading branch information
ala-n committed Dec 20, 2023
1 parent 1497b19 commit f6c84af
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 23 deletions.
5 changes: 3 additions & 2 deletions src/modules/all.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Core
export {ESLBaseElement, ESLBaseElementShape} from './esl-base-element/core';
export {ESLMixinElement} from './esl-mixin-element/core';
export * from './esl-base-element/core';
export * from './esl-mixin-element/core';

export * from './esl-utils/all';
export * from './esl-media-query/core';
export * from './esl-traversing-query/core';
Expand Down
7 changes: 0 additions & 7 deletions src/modules/esl-base-element/core.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
export type {ESLBaseElementShape} from './core/esl-base-element.shape';

export * from './core/esl-base-element';

export * from '../esl-utils/decorators/prop';
export * from '../esl-utils/decorators/attr';
export * from '../esl-utils/decorators/bool-attr';
export * from '../esl-utils/decorators/json-attr';

export * from '../esl-utils/decorators/listen';
3 changes: 2 additions & 1 deletion src/modules/esl-base-element/test/element.listener.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import '../../../polyfills/es5-target-shim';

import {ESLBaseElement, listen} from '../core';
import {ESLBaseElement} from '../core';
import {listen} from '../../esl-utils/decorators/listen';
import {randUID} from '../../esl-utils/misc/uid';
import {ESLEventUtils} from '../../esl-utils/dom/events';

Expand Down
4 changes: 2 additions & 2 deletions src/modules/esl-footnotes/core/esl-note.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {ExportNs} from '../../esl-utils/environment/export-ns';
import {ESLBaseElement, prop} from '../../esl-base-element/core';
import {ready, attr, boolAttr, memoize, listen} from '../../esl-utils/decorators';
import {ESLBaseElement} from '../../esl-base-element/core';
import {ready, attr, prop, boolAttr, memoize, listen} from '../../esl-utils/decorators';
import {ESLTooltip} from '../../esl-tooltip/core';
import {promisifyTimeout, repeatSequence} from '../../esl-utils/async';
import {ESLEventUtils} from '../../esl-utils/dom/events';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {ESLBaseElement, listen} from '../../../esl-base-element/core';
import {ESLBaseElement} from '../../../esl-base-element/core';
import {listen} from '../../../esl-utils/decorators/listen';
import {ESLEventUtils} from '../../../esl-utils/dom/events';

/** Interface for option definition */
Expand Down
7 changes: 0 additions & 7 deletions src/modules/esl-mixin-element/core.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1 @@
export * from './ui/esl-mixin-element';

export * from '../esl-utils/decorators/prop';
export * from '../esl-utils/decorators/attr';
export * from '../esl-utils/decorators/bool-attr';
export * from '../esl-utils/decorators/json-attr';

export * from '../esl-utils/decorators/listen';
3 changes: 2 additions & 1 deletion src/modules/esl-mixin-element/test/mixin.listener.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {ESLMixinElement, listen} from '../core';
import {ESLMixinElement} from '../core';
import {listen} from '../../esl-utils/decorators/listen';
import {ESLEventUtils} from '../../esl-utils/dom/events';

describe('ESLMixinElement: listeners', () => {
Expand Down
3 changes: 2 additions & 1 deletion src/modules/esl-toggleable/core/esl-toggleable-dispatcher.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {ESLBaseElement, listen} from '../../esl-base-element/core';
import {ESLBaseElement} from '../../esl-base-element/core';
import {listen} from '../../esl-utils/decorators/listen';
import {getCompositeTarget} from '../../esl-utils/dom/events';
import {ExportNs} from '../../esl-utils/environment/export-ns';
import {ESLToggleable} from './esl-toggleable';
Expand Down
1 change: 0 additions & 1 deletion src/modules/esl-utils/fixes/viewport.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {rafDecorator} from '../async/raf';
import {DeviceDetector} from '../environment/device-detector';

/**
* Small utility to provide 100vw and 100vh alternative CSS Variables
Expand Down

0 comments on commit f6c84af

Please sign in to comment.