Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(esl-utils): split scroll.ts file and add scroll into view example pages #1022

Merged
merged 11 commits into from
Jun 9, 2022

Conversation

fshovchko
Copy link
Contributor

In the scope of this PR I made following changes:

  • Added two example pages for ScrollIntoView. One is for testing empty page scrollIntoView, where window scroll height is bigger than screen and one for testing scroll with dynamic elements and test all scroll possible options
  • Splitted scroll.ts file code in separate files

@fshovchko fshovchko self-assigned this Jun 7, 2022
@fshovchko fshovchko changed the base branch from main to main-beta June 7, 2022 18:50
@fshovchko fshovchko changed the title refactor(esl-utils): split scroll.ts file and add scroll into view exdample pages refactor(esl-utils): split scroll.ts file and add scroll into view example pages Jun 7, 2022
@fshovchko fshovchko requested a review from ala-n June 7, 2022 18:51
@ala-n ala-n requested review from a team, dshovchko and julia-murashko and removed request for a team June 9, 2022 00:21
@ala-n ala-n added the enhancement Improvements and additions to code label Jun 9, 2022
@ala-n ala-n merged commit 3d6fae0 into main-beta Jun 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
@ala-n
Copy link
Collaborator

ala-n commented Jun 16, 2022

🎉 This PR is included in version 4.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n deleted the refactor/split-scroll-file branch July 6, 2022 12:35
@ala-n
Copy link
Collaborator

ala-n commented Oct 5, 2022

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvements and additions to code released on @beta released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants