Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epic (esl-share): initial implementation #1358
epic (esl-share): initial implementation #1358
Changes from 78 commits
bc2cc7f
741fbee
6213f36
0ff835a
9e0fb79
3e0a2b0
1e851d0
8411343
d176117
6620a7c
ab4469d
d72bcd8
b830900
e3eafc5
126f79b
39dd3d9
7711733
39a9d69
3690d02
aa64b59
59480a3
07fc40a
5c6ec49
df36651
9ed21fc
40637cf
11ee61a
0adad11
7a6aa35
84ad6f4
0f33fe1
dcce8af
258b1d3
79c6ea2
aebc38a
80c890f
6d3cbd2
c647d9d
11c2733
7628070
ae70066
2a73734
9c82115
614cb24
d32ad18
f38d402
dbffaf3
c84855a
a6e5b86
d519d41
9542ffb
70ec8a6
477b71a
b3861c0
4c1fe2c
2830c46
68abccc
5ef927a
7c1d8c9
776db91
af3dd01
52d4144
2448ac9
ab391fe
cf17913
dbcbc3b
57facab
2bd45d6
c676ece
a31b24e
76bbf72
0c70abb
05c810e
8e9470c
4a56f94
8679639
9655200
10698fd
37edb5d
a7f35c2
ac5f7ed
f649e47
5f9bf92
40b085b
c86c426
9c8f763
ee0e8c5
edb43e3
e07d543
7872cf3
a522ba7
de671dd
e9a833d
63e1da4
f9011a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cosmetic: we need to think about more accessible or prepared value by default.
It is strange if we give an action that the user needs to overwrite anyway (as it is not internalized|prepared|etc.) if we are talking about prod usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed (02.03)
Alert config moved as additionalParams to the action configuration
Passs this param to the button as an
additionalParams
field (@prop / @jsonParam)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need an aria-label? span is a block that's a11y representation is equal to the content by default