[🚩esl-modal]: beta release version of esl-modal module #1969

NastaLeo · 2023-10-02T12:32:00Z

Closes: #1376

Description: Remove the full version of the polyfill for ESL UI site renderer Remove shims and targets =ES5 in the site codebase Remove ES5-related OOTB ESL polyfills except es5-target-shim.ts Drop support for IE11 and ES5 target BREAKING CHANGES: ESL UI site renderer and ESL polyfills no longer support IE11 and ES5 target.

Description: Remove the medium version of the polyfill for ESL UI site renderer Drop support for Edge old versions and ES6 polyfils BREAKING CHANGES: ESL UI site renderer and ESL polyfills no longer support Edge old versions and ES6 polyfils.

refactor: Drop IE11 support

Co-authored-by: ala'n (Alexey Stsefanovich) <astsefanovich@exadel.com> BREAKING CHANGE: `ESLEventUtils.descriptors` alias of `ESLEventUtils.getAutoDescriptors` is no longer supported BREAKING CHANGE: `EventUtils` alias of `ESLEventUtils` is no longer supported BREAKING CHANGE: `esl-media-quey` module no longer supports `addListener` and `removeListener` shorthand BREAKING CHANGE: `SynteticEventTarget` no longer supports `addListener` and `removeListener` shorthand BREAKING CHANGE: 'fallback-duration' is no longer in the JSX shape of ESLPanel and ESLPanelGroup BREAKING CHANGE: `ToggleableActionParams` alias of `ESLToggleableActionParams` is no longer supported BREAKING CHANGE: `TraversingQuery` alias of `ESLTraversingQuery` is no longer supported BREAKING CHANGE: `RTLUtils` retired use separate methods instead BREAKING CHANGE: `TraversingUtils` retired use separate methods instead BREAKING CHANGE: `deepCompare` alias of `isEqual` is no longer supported BREAKING CHANGE: `generateUId` alias of `randUID` no longer supported

Deprecation: use `Array.prototype.flat` instead of `flat` utility

# Conflicts: # package-lock.json # package.json

…leanup

BREAKING CHANGE: `hasEventListener` no longer accepts min number value use `this.getEventListeners(type).length` to make extended checks BREAKING CHANGE: `dispatchEvent` does not accepts target argument

BREAKING CHANGE: `createZIndexIframe` and `is-fixes` module no longer available due to drop of IE11 support

feat: ES5/IE11 cleanup (part 1)

…r testing (#1376) Closes: #1376

…trigger

feat(esl-toggleable): introducing a base trigger class in purpose to simplify and make Trigger-Toggleable constructions more API strict in ESL

# Conflicts: # package-lock.json

dshovchko · 2024-01-04T13:23:31Z

src/modules/esl-utils/test/template.ts

+    if (!this.cache[selector]) {
+      this.cache[selector] = this.$fragment.querySelector(selector);
+    }
+    return this.cache[selector];


I guess you missed clearing the cache in the clear() method (in row number 52).

dshovchko · 2024-01-04T13:27:55Z

src/modules/esl-modal/test/modal.stack.test.ts

+      expect(ESLModalStack.store[1]).toBe(TEMPLATE.$modal2);
+      expect(ESLModalStack.store.length).toBe(2);
+    });
+    test('Closing and removing parent modal from store leads to hide all nested modals in case their are opened before target modal closes and its removing from store', () => {


I think it can be simplified

Suggested change

test('Closing and removing parent modal from store leads to hide all nested modals in case their are opened before target modal closes and its removing from store', () => {

test('Removing the parent modal leads to hiding all nested modals if opened', () => {

fix: popup has wrong positioning leads to a broken popup layout

refactor: small optimization/unification of `Rect` usage in popup

# [5.0.0-beta.4](v5.0.0-beta.3...v5.0.0-beta.4) (2024-01-05) ### Bug Fixes * **esl-utils:** fix getting viewport sizes ([c17d2e3](c17d2e3)) ### Features * **esl-toggleable:** introducing a base trigger class in purpose to simplify and make Trigger-Toggleable constructions more API strict in ESL ([4ea1565](4ea1565))

# [5.0.0-beta.5](v5.0.0-beta.4...v5.0.0-beta.5) (2024-01-05)

# [5.0.0-beta.6](v5.0.0-beta.5...v5.0.0-beta.6) (2024-01-05)

# [5.0.0-beta.7](v5.0.0-beta.6...v5.0.0-beta.7) (2024-01-05)

…ic/esl-modal # Conflicts: # site/src/localdev.ts # site/views/examples/modal.njk

HenadzV and others added 30 commits March 17, 2023 04:55

refactor: Get rid of the polyfill bundle suffix

f48ee1e

Merge pull request #1502 from exadel-inc/tech/polyfill-full

a442a3a

refactor: Drop IE11 support

fix(esl-utils): simplified union utility

043fe45

fix(esl-utils): fix types for unwrap array utility

a4b432a

fix(esl-utils): simplified uniq array utility

45f282f

fix(esl-utils): simplified flat array utility

788a782

Deprecation: use `Array.prototype.flat` instead of `flat` utility

Merge branch 'main' of github.com:exadel-inc/esl into main-next

e24b48b

# Conflicts: # package-lock.json # package.json

Merge branch 'main-next' of github.com:exadel-inc/esl into feat/es5-c…

a5c0a7c

…leanup

fix(esl-utils): SyntheticEventTarget optimizations

a4c9b8d

BREAKING CHANGE: `hasEventListener` no longer accepts min number value use `this.getEventListeners(type).length` to make extended checks BREAKING CHANGE: `dispatchEvent` does not accepts target argument

fix(esl-utils): createZIndexIframe retired

ad678cb

BREAKING CHANGE: `createZIndexIframe` and `is-fixes` module no longer available due to drop of IE11 support

fix(esl-utils): clean IE11 micro-optimizations

7ed8830

Merge pull request #1633 from exadel-inc/feat/es5-cleanup

c4095f2

feat: ES5/IE11 cleanup (part 1)

style(esl-modal): fix button focus

8d55fb7

feat(esl-modal): beta version of esl-modal created and available fo…

f1ac459

…r testing (#1376) Closes: #1376

docs(esl-modal): add modal examples

52e5df7

test(esl-modal): add test for esl-modal

e7f0201

style(esl-modal): resolve conflicts

6a3658b

style(esl-modal): apply suggestion from code review

832f5a9

test(esl-modal): update tests

800073c

style(esl-modal): fix esl-modal module imports

267e1ff

Merge branch 'epic/modal' into epic/esl-modal

e0bdaa1

refactor(esl-modal): code cleanup wave 1

df861d6

Merge branch 'main' of github.com:exadel-inc/esl into epic/esl-modal

6682f0a

refactor(esl-modal): create modal-backdrop custom element

d9a55ab

refactor(esl-modal): add placeholder support

2291e27

refactor(esl-modal): enhance placeholder appearance check

46554df

Merge branch 'main' of github.com:exadel-inc/esl into epic/esl-modal

d4d769c

ala-n and others added 11 commits December 27, 2023 07:45

Merge branch 'main-beta' of github.com:exadel-inc/esl into feat/base-…

30b27a8

…trigger

docs(esl-trigger): improve TSDoc for hoverShowDelay/hoverHideDelay

9da43c2

Merge pull request #2121 from exadel-inc/feat/base-trigger

1d7e197

feat(esl-toggleable): introducing a base trigger class in purpose to simplify and make Trigger-Toggleable constructions more API strict in ESL

Merge branch 'main' of github.com:exadel-inc/esl into main-beta

bc49066

Merge branch 'main' into main-beta

cd25da0

# Conflicts: # package-lock.json

chore(site): fix polyfill bundle

ff6c704

docs(esl-modal): update documentation

ab9d949

refactor(esl-popup): replacement of deprecated properties

e8cabbe

fix(esl-utils): fix getting viewport sizes

c17d2e3

docs(esl-utils): fix tsdoc

99dd7fa

Merge remote-tracking branch 'origin/main' into fix/get-window-rect

ef705d3

dshovchko reviewed Jan 4, 2024

View reviewed changes

dshovchko and others added 18 commits January 4, 2024 15:44

Merge remote-tracking branch 'origin/main' into fix/get-window-rect

c877c34

chore: merge main state to main-beta

82702c4

Merge branch 'main' of github.com:exadel-inc/esl into main-beta

9f5a4ab

docs: fix polyfills.ts doc syntax

60b8cc6

Merge pull request #2145 from exadel-inc/fix/get-window-rect

385d638

fix: popup has wrong positioning leads to a broken popup layout

refactor: small optimization/unification of Rect usage in popup

0e08b58

Merge pull request #2146 from exadel-inc/tech/popup-rect-upd

dcbf1ba

refactor: small optimization/unification of `Rect` usage in popup

chore(patch): fix npm prepare didn't complete for npm pack command

2864824

chore(release): 5.0.0-beta.5

19efcc8

# [5.0.0-beta.5](v5.0.0-beta.4...v5.0.0-beta.5) (2024-01-05)

chore(patch): alternative fix for npm pack files

bdf0bea

chore(release): 5.0.0-beta.6

8476060

# [5.0.0-beta.6](v5.0.0-beta.5...v5.0.0-beta.6) (2024-01-05)

chore(patch): fix for npm pack of submodules (eslint-plugin-esl)

3ccd853

chore(release): 5.0.0-beta.7

9375711

# [5.0.0-beta.7](v5.0.0-beta.6...v5.0.0-beta.7) (2024-01-05)

Merge branch 'main-beta' of https://github.com/exadel-inc/esl into ep…

dc4172a

…ic/esl-modal # Conflicts: # site/src/localdev.ts # site/views/examples/modal.njk

test(esl-modal): update tests

270de48

docs(esl-modal): enhance documentation

f316873

style(esl-modal): small update after toggleable changes

27aecdb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[🚩esl-modal]: beta release version of esl-modal module #1969

[🚩esl-modal]: beta release version of esl-modal module #1969

NastaLeo commented Oct 2, 2023

dshovchko Jan 4, 2024

dshovchko Jan 4, 2024

	test('Closing and removing parent modal from store leads to hide all nested modals in case their are opened before target modal closes and its removing from store', () => {
	test('Removing the parent modal leads to hiding all nested modals if opened', () => {

[🚩esl-modal]: beta release version of esl-modal module #1969

Are you sure you want to change the base?

[🚩esl-modal]: beta release version of esl-modal module #1969

Conversation

NastaLeo commented Oct 2, 2023

dshovchko Jan 4, 2024

Choose a reason for hiding this comment

dshovchko Jan 4, 2024

Choose a reason for hiding this comment