Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): handle sanpshot's size mismatch #2670

Open
wants to merge 2 commits into
base: main-beta
Choose a base branch
from
Open

test(e2e): handle sanpshot's size mismatch #2670

wants to merge 2 commits into from

Conversation

fshovchko
Copy link
Contributor

After test run of a new snapshot matcher implementation, it was discovered that reports became less informative.
The most important things are:

  • Missing reports on when two snapshot have mismatching size
  • Error messages are less informative

@fshovchko fshovchko added needs review The PR is waiting for review e2e labels Sep 19, 2024
@fshovchko fshovchko requested a review from a team September 19, 2024 13:22
@fshovchko fshovchko self-assigned this Sep 19, 2024
@fshovchko fshovchko requested review from dshovchko, yadamskaya and abarmina and removed request for a team September 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshovchko dshovchko Awaiting requested review from dshovchko dshovchko was automatically assigned from exadel-inc/esl-core-team

@yadamskaya yadamskaya Awaiting requested review from yadamskaya yadamskaya was automatically assigned from exadel-inc/esl-core-team

@abarmina abarmina Awaiting requested review from abarmina abarmina was automatically assigned from exadel-inc/esl-core-team

Assignees

@fshovchko fshovchko

Labels
e2e needs review The PR is waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fshovchko