-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esl-footnotes): migrate esl-note to esl-base-trigger #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshovchko
added
enhancement
Improvements and additions to code
needs review
The PR is waiting for review
labels
Sep 30, 2024
dshovchko
requested review from
ala-n,
yadamskaya,
abarmina,
Natalie-Smirnova,
fshovchko,
HenadzV,
NastaLeo and
a team
September 30, 2024 15:55
ala-n
approved these changes
Sep 30, 2024
Co-authored-by: ala'n (Alexey Stsefanovich) <astsefanovich@exadel.com>
ala-n
approved these changes
Oct 1, 2024
NastaLeo
approved these changes
Oct 1, 2024
abarmina
approved these changes
Oct 1, 2024
Natalie-Smirnova
approved these changes
Oct 7, 2024
Postponed for one release late |
🎉 This PR is included in version 5.0.0-beta.38 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
Improvements and additions to code
needs review
The PR is waiting for review
released on @beta
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLNote has been migrated on the base trigger element
Closes: #2683