Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esl-footnotes): migrate esl-note to esl-base-trigger #2690

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

dshovchko
Copy link
Collaborator

ESLNote has been migrated on the base trigger element

Closes: #2683

@dshovchko dshovchko added enhancement Improvements and additions to code needs review The PR is waiting for review labels Sep 30, 2024
@dshovchko dshovchko self-assigned this Sep 30, 2024
src/modules/esl-footnotes/core/esl-note.ts Outdated Show resolved Hide resolved
Co-authored-by: ala'n (Alexey Stsefanovich) <astsefanovich@exadel.com>
@ala-n
Copy link
Collaborator

ala-n commented Oct 17, 2024

Postponed for one release late

@ala-n ala-n added the postponed Postponed issue label Oct 17, 2024
@ala-n ala-n removed the postponed Postponed issue label Oct 29, 2024
@ala-n ala-n merged commit 10cd836 into main-beta Oct 29, 2024
7 checks passed
@ala-n ala-n deleted the feat/esl-note-to-base-trigger branch October 29, 2024 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
@ala-n
Copy link
Collaborator

ala-n commented Nov 4, 2024

🎉 This PR is included in version 5.0.0-beta.38 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvements and additions to code needs review The PR is waiting for review released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants