Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update User Guide Documentation #66

Closed
belenaj opened this issue Feb 3, 2020 · 11 comments
Closed

Update User Guide Documentation #66

belenaj opened this issue Feb 3, 2020 · 11 comments

Comments

@belenaj
Copy link

belenaj commented Feb 3, 2020

After the new 0.6.0 release, user guide seems outdated. (How to use import/export functions)
CONNECTION_NAME
https://github.com/exasol/cloud-storage-etl-udfs/blob/master/docs/user_guide.md

@morazow
Copy link
Contributor

morazow commented Feb 3, 2020

Hey @belenaj,

Thanks for the feedback!

The one in the user guide seems to be an example. The usage for connection object are available in cloud_storages.md.

@belenaj
Copy link
Author

belenaj commented Feb 3, 2020

True!
I checked the wrong file, thanks!

@dmitry-lu
Copy link
Contributor

dmitry-lu commented Mar 4, 2020

Hi @morazow
I had the same question as @belenaj and wanted to open a similar ticket. And then found out that the topic #66 was already created.
As two people had the same idea - I'm proposing a change #76

@morazow
Copy link
Contributor

morazow commented Mar 5, 2020

Hello @dmitry-lu, @belenaj

I have merged it. Thanks for the feedback and pull request!

@morazow morazow closed this as completed Mar 5, 2020
@morazow
Copy link
Contributor

morazow commented Mar 5, 2020

Hello @dmitry-lu,

I am very sorry, but because I did the squash merge of your pull request it made me the author of the commit. This was not the case previously, and it is not acceptable from our side. We want to retain the commit authorship and give credit to our collaborators!

Could you please send me your Github email? Then I am going to amend the author. You can also send it via email to muhammet.orazov at exasol dot com.

Again thanks for the feedback!

Best,
Muhammet

@morazow
Copy link
Contributor

morazow commented Mar 6, 2020

Okay, I learned that this was due to the recent Github change.

It has already outrages most of the open-source ecosystem. I hope they update this change to include the original author.

Anyway, please send me the email you have used with the Github, then I can amend the commit author.

@tkilias
Copy link
Contributor

tkilias commented Mar 6, 2020

@morazow Github wanted to revert this change. See here for more details.

@morazow
Copy link
Contributor

morazow commented Mar 6, 2020

Hey @tkilias ,

Great! Okay, let me wait a while, maybe the authorship automatically assigned.

@tkilias
Copy link
Contributor

tkilias commented Mar 6, 2020

@morazow Unfortunately, this won't fix existing squashed merges. So, if you already merged, than you need to amend the commit.

@morazow
Copy link
Contributor

morazow commented Mar 6, 2020

@tkilias, okay that is good to know. Then, I will do that once the @dmitry-lu sends his email.

@dmitry-lu
Copy link
Contributor

dmitry-lu commented Mar 6, 2020

Hi @morazow

Thank you for noticing this and for raising the topic, it's very thoughtful of you!
👍
I will ping you via your exasol mail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants