Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply patch from Hari Nair (CommScope) #43

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

morazow
Copy link
Contributor

@morazow morazow commented Oct 11, 2019

It adds additional user parameters when using udf to import from Kafka clusters. Additionally, improves the Kafka consumer application code.

Thanks Hari for your feedback and contributions!

Fixes #41.

Thanks for your feedback and contributions!

Fixes #41.
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #43 into develop will decrease coverage by 2.48%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
- Coverage    79.61%   77.13%   -2.49%     
===========================================
  Files           30       30              
  Lines          682      704      +22     
  Branches        71       74       +3     
===========================================
  Hits           543      543              
- Misses         139      161      +22
Impacted Files Coverage Δ
.../exasol/cloudetl/scriptclasses/KafkaMetadata.scala 0% <0%> (ø) ⬆️
...om/exasol/cloudetl/scriptclasses/KafkaImport.scala 0% <0%> (ø) ⬆️
...xasol/cloudetl/kafka/KafkaConsumerProperties.scala 0% <0%> (ø) ⬆️
...main/scala/com/exasol/cloudetl/bucket/Bucket.scala 96.96% <0%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9fd757...fc7d029. Read the comment docs.

@morazow morazow merged commit 91ee7b9 into develop Oct 11, 2019
@morazow morazow deleted the patch/fix-#41-feedback-from-hari-commscope branch October 28, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant