Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#49: Extract common code for virtual schema extensions #50

Merged
merged 29 commits into from
Nov 3, 2023
Merged

#49: Extract common code for virtual schema extensions #50

merged 29 commits into from
Nov 3, 2023

Conversation

kaklakariada
Copy link
Collaborator

Closes #49

@kaklakariada
Increment version
f9c320a
@kaklakariada
Fix vulnerability in dev dependencies
6217d1b
@kaklakariada
Cleanup
4ece76f
@kaklakariada
Update version number
b641954
@kaklakariada
#49: Add initial version of VS Base Extension
182786c
@kaklakariada
#49: Implement findInstances()
f078514
@kaklakariada
Add "addInstance()" request
089702e
@kaklakariada
#49: Implement creating virtual schema
5f7a3c5
@kaklakariada
Add support for ADAPTER scripts
5eed8d2
@kaklakariada
Fix CREATE VIRTUAL SCHEMA syntax
bc02e29
@kaklakariada
Fix dropping adapter scripts
59828e7
@kaklakariada
Centralize version check
4763c27
@kaklakariada
resolveOptional resolves missing required parameters
031cc9f
@kaklakariada
Cleanup queries
c4d48a7
@kaklakariada
Added tests for addInstance()
110b00c
@kaklakariada
Fix linter warnings
b84c546
@kaklakariada
Increment minor version and upgrade dependencies
26f95c6
@kaklakariada
Remove unused methods
7fedd03
@kaklakariada
Update API version
a25ab0b
@kaklakariada
Simplify unit test
b905c2c
@kaklakariada
Fix compiler warnings
23027fe
@kaklakariada
Add unit tests
b3f84c1
@kaklakariada
Improve test coverage
aab3608
@kaklakariada
Don't return default value for missing parameter values
c50b563
@kaklakariada
Update release date
a4277a1
@kaklakariada
Remove unused "adapterName" property
dfe4bb6
ckunki
ckunki requested changes Nov 2, 2023
View reviewed changes
src/base-vs/index.ts Show resolved Hide resolved
src/base-vs/index.ts Show resolved Hide resolved
src/base-vs/index.ts Show resolved Hide resolved
src/base-vs/builders.ts Outdated Show resolved Hide resolved
src/base-vs/parameterResolver.ts Outdated Show resolved Hide resolved
src/base-vs/addInstance.ts Outdated Show resolved Hide resolved
src/base-vs/parameterResolver.test.ts Outdated Show resolved Hide resolved
ckunki
ckunki previously approved these changes Nov 2, 2023
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kaklakariada kaklakariada merged commit 4f0f1e2 into main Nov 3, 2023
4 checks passed
@kaklakariada kaklakariada deleted the kaklakariada/issue49 branch November 3, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckunki ckunki ckunki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract common code for VS extensions
2 participants
@kaklakariada @ckunki