Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for the environment variable LOG_ENV_VARIABLE_NAME #322

Closed
tkilias opened this issue May 12, 2023 · 0 comments · Fixed by #360
Closed

Add test for the environment variable LOG_ENV_VARIABLE_NAME #322

tkilias opened this issue May 12, 2023 · 0 comments · Fixed by #360
Assignees
@tkilias @MarleneKress79789
Labels
bug Unwanted / harmful behavior

Comments

@tkilias
Copy link
Contributor

tkilias commented May 12, 2023 •
edited
Loading

Background

  • We use the run_task function in commons.py for running the root luigi task, which then causes all dependent tasks to run
  • The run_task function configures the logging for luigi
  • A user can redirect the output to a file with the environment variable LOG_ENV_VARIABLE_NAME
  • The environment variable LOG_ENV_VARIABLE_NAME is used here
  • Currently, we don't have a test for this function

Acceptance Test

  • Add test for the environment variable LOG_ENV_VARIABLE_NAME
@tkilias tkilias added the bug Unwanted / harmful behavior label May 12, 2023
tkilias added a commit to exasol/script-languages-container-tool that referenced this issue May 12, 2023
@tkilias
Remove test_docker_build_direct.py, because it got outdated with the …
93b4c9f 
…current changes of the logging in the itde. Testing of the environment variable LOG_ENV_VARIABLE_NAME should be implemented in the itde with exasol/integration-test-docker-environment#322.
tkilias added a commit to exasol/script-languages-container-tool that referenced this issue May 12, 2023
@tkilias
#192: Removed setup.py (#195)
e286fb2 
* Removed setup.py
* Changed docker runner to install the package via poetry 
* Updated the integration-test-docker-environment to 1.6.0
* Remove test_docker_build_direct.py, because it got outdated with the current changes of the logging in the itde. Testing of the environment variable LOG_ENV_VARIABLE_NAME should be implemented in the itde with exasol/integration-test-docker-environment#322.
@MarleneKress79789 MarleneKress79789 self-assigned this Jul 5, 2023
@MarleneKress79789 MarleneKress79789 mentioned this issue Jul 7, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkilias tkilias

@MarleneKress79789 MarleneKress79789

Labels
bug Unwanted / harmful behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed env variable LOG_ENV_VARIABLE_NAME exasol/integration-test-docker-environment
2 participants
@tkilias @MarleneKress79789