Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date dependent tests by upgrading to new Metabase release #14

Closed
kaklakariada opened this issue Jan 10, 2022 · 0 comments · Fixed by #22
Closed

Fix date dependent tests by upgrading to new Metabase release #14

kaklakariada opened this issue Jan 10, 2022 · 0 comments · Fixed by #22
Assignees
@kaklakariada
Labels
bug Something isn't working
Milestone
GA

Comments

@kaklakariada
Copy link
Collaborator

kaklakariada commented Jan 10, 2022 •
edited
Loading

Some Metabase tests depend on the current date. If the year changes, they fail.
Metabase already fixed the tests on master branch. Once a new release of Metabase is available (see https://github.com/metabase/metabase/releases), reactivate the following tests:

FAIL in metabase.query-processor-test.implicit-joins-test/implicit-joins-with-expressions-test (implicit_joins_test.clj:145)

:exasol Should be able to run query with multiple implicit joins and breakouts using sample-dataset dataset
expected: [["Doohickey" "Facebook" "2019-01-01T00:00:00Z" 0 263]
           ["Doohickey" "Facebook" "2020-01-01T00:00:00Z" 0 89]
           ["Doohickey" "Google" "2019-01-01T00:00:00Z" 0 276]
           ["Doohickey" "Google" "2020-01-01T00:00:00Z" 0 100]
           ["Gizmo" "Facebook" "2019-01-01T00:00:00Z" 0 361]]
  actual: ([["Doohickey" "Facebook" "2020-01-01T00:00:00Z" 0 89]
            ["Doohickey" "Google" "2020-01-01T00:00:00Z" 0 100]
            ["Gizmo" "Facebook" "2020-01-01T00:00:00Z" 0 113]
            ["Gizmo" "Google" "2020-01-01T00:00:00Z" 0 101]])

FAIL in metabase.query-processor.pivot-test/dont-return-too-many-rows-test (pivot_test.clj:167)
Make sure pivot queries don't return too many rows (#14329)
expected: [["Doohickey" "Facebook" "2019-01-01T00:00:00Z" 0 263]
           ["Doohickey" "Facebook" "2020-01-01T00:00:00Z" 0 89]
           ["Doohickey" "Google" "2019-01-01T00:00:00Z" 0 276]
           ["Doohickey" "Google" "2020-01-01T00:00:00Z" 0 100]
           ["Gizmo" "Facebook" "2019-01-01T00:00:00Z" 0 361]
           ["Gizmo" "Facebook" "2020-01-01T00:00:00Z" 0 113]
           ["Gizmo" "Google" "2019-01-01T00:00:00Z" 0 325]
           ["Gizmo" "Google" "2020-01-01T00:00:00Z" 0 101]
           ["Doohickey" "Facebook" nil 4 352]
           ["Doohickey" "Google" nil 4 376]
           ["Gizmo" "Facebook" nil 4 474]
           ["Gizmo" "Google" nil 4 426]
           ["Doohickey" nil nil 6 728]
           ["Gizmo" nil nil 6 900]
           [nil nil nil 7 1628]]
  actual: ([["Doohickey" "Facebook" "2020-01-01T00:00:00Z" 0 89]
            ["Doohickey" "Google" "2020-01-01T00:00:00Z" 0 100]
            ["Gizmo" "Facebook" "2020-01-01T00:00:00Z" 0 113]
            ["Gizmo" "Google" "2020-01-01T00:00:00Z" 0 101]
            ("Doohickey" "Facebook" nil 4 89)
            ("Doohickey" "Google" nil 4 100)
            ("Gizmo" "Facebook" nil 4 113)
            ("Gizmo" "Google" nil 4 101)
            ("Doohickey" nil nil 6 189)
            ("Gizmo" nil nil 6 214)
            (nil nil nil 7 403)])
@kaklakariada kaklakariada added bug Something isn't working source:exasol labels Jan 10, 2022
@kaklakariada kaklakariada added this to the GA milestone Jan 10, 2022
@kaklakariada kaklakariada changed the title Fix timestamp dependent tests by upgrading to new Metabase release Fix date dependent tests by upgrading to new Metabase release Jan 13, 2022
@kaklakariada kaklakariada mentioned this issue Jan 13, 2022
Closed
kaklakariada added a commit that referenced this issue Jan 17, 2022
@kaklakariada
#14 Upgrade to Metabase 0.41.6
ab5c034
@kaklakariada kaklakariada mentioned this issue Jan 17, 2022
Merged
kaklakariada added a commit that referenced this issue Jan 17, 2022
@kaklakariada
#14: Re-activate date dependent tests
a64ea03 
These tests are fixed in the new Metabase version
kaklakariada added a commit that referenced this issue Jan 17, 2022
@kaklakariada
Merge remote-tracking branch 'origin/main' into #14-upgrade-metabase
ed0988d
kaklakariada added a commit that referenced this issue Jan 17, 2022
@kaklakariada
Merge branch '#14-upgrade-metabase' into #3-filter-join-subselect
741d0be
@kaklakariada kaklakariada self-assigned this Jan 18, 2022
kaklakariada added a commit that referenced this issue Jan 18, 2022
@kaklakariada
Upgrade Metabase (#22)
8c85a7d 
* #14 Upgrade to Metabase 0.41.6

* Increment version number of driver

* #14: Re-activate date dependent tests

These tests are fixed in the new Metabase version

* Add changelog entry

* Hide unwanted files in vscode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

Labels
bug Something isn't working
Projects
None yet
Milestone
GA
Development

Successfully merging a pull request may close this issue.

Upgrade Metabase exasol/metabase-driver
2 participants
@kaklakariada @jakobbraun