Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reading driver version from metabase-plugin.yaml #40

Closed
kaklakariada opened this issue May 20, 2022 · 0 comments · Fixed by #44
Closed

Implement reading driver version from metabase-plugin.yaml #40

kaklakariada opened this issue May 20, 2022 · 0 comments · Fixed by #44
Assignees
@kaklakariada
Labels
feature New feature or request

Comments

@kaklakariada
Copy link
Collaborator

After implementing #35 the driver jar does not contain META-INF/maven/metabase/exasol-driver/pom.properties any more. We used this file for reading the driver version.

Now we need to read the version from metabase-plugin.yaml included in the jar.
@kaklakariada kaklakariada added the feature New feature or request label May 20, 2022
kaklakariada added a commit that referenced this issue May 20, 2022
@kaklakariada
Remove code to get driver version
49ac2a4 
This will be fixed in #40
kaklakariada added a commit that referenced this issue May 24, 2022
@kaklakariada
Migrate to tools.dep (#36)
daf3259 
* Migrate to tools.dep

* Cleanup developer guide

* Remove code to get driver version

This will be fixed in #40

* Install driver for running integration tests

This avoids error

java.lang.IllegalArgumentException: No method in multimethod 'connection-properties' for dispatch value: :exasol

* Build frontend to fix failing integration tests

 ERROR in metabase.pulse.render.js-svg-test/combo-test (js_engine.clj:38)
[PRO TIP] If this test fails, you may need to rebuild the bundle with `yarn build-static-viz`

Uncaught exception, not in assertion.

clojure.lang.ExceptionInfo: Javascript resource not found: frontend_client/app/dist/lib-static-viz.bundle.js
    source: "frontend_client/app/dist/lib-static-viz.bundle.js"

* Upgrade to Metabase 0.43.1

* Remove features not supported in the latest release of metabase

* Activate linting with clj kondo
@kaklakariada kaklakariada mentioned this issue May 25, 2022
Closed
2 tasks
@kaklakariada kaklakariada self-assigned this May 30, 2022
kaklakariada added a commit that referenced this issue May 30, 2022
@kaklakariada
#40: Read driver version from plugin yaml
59763d7
@kaklakariada kaklakariada mentioned this issue May 30, 2022
Merged
kaklakariada added a commit that referenced this issue May 30, 2022
@kaklakariada
#40: Read driver version from plugin yaml (#44)
0993812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#40: Read driver version from plugin yaml exasol/metabase-driver
1 participant
@kaklakariada