Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Exasol JDBC driver form built driver jar #41

Closed
kaklakariada opened this issue May 24, 2022 · 0 comments · Fixed by #42
Closed

Remove Exasol JDBC driver form built driver jar #41

kaklakariada opened this issue May 24, 2022 · 0 comments · Fixed by #42
Labels
bug Something isn't working

Comments

@kaklakariada
Copy link
Collaborator

To simplify dependency management we need to remove the JDBC driver from the build driver jar.
This was introduced with the migration of the build system to deps.edn in #36
@kaklakariada kaklakariada added the bug Something isn't working label May 24, 2022
kaklakariada added a commit that referenced this issue May 25, 2022
@kaklakariada
#41: Remove JDBC driver from uberjar
773f813
This was referenced May 25, 2022
Merged
Closed
kaklakariada added a commit that referenced this issue May 27, 2022
@kaklakariada
#41 Remove jdbc driver from jar (#42)
1bc5ede 
* Configure manifest to run tests without installing the driver

See https://discourse.metabase.com/t/running-integration-tests-with-deps-edn-build-without-symlink/20157/7

* #41: Remove JDBC driver from uberjar

* Add note about removed version logging

* Implement review findings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#41 Remove jdbc driver from jar exasol/metabase-driver
1 participant
@kaklakariada