Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document known issue with hard coded first day of the week #63

Closed
kaklakariada opened this issue Feb 2, 2023 · 0 comments · Fixed by #64
Closed

Document known issue with hard coded first day of the week #63

kaklakariada opened this issue Feb 2, 2023 · 0 comments · Fixed by #64
Assignees
@kaklakariada
Labels
documentation Improvements or additions to documentation

Comments

@kaklakariada
Copy link
Collaborator

In #59 we found out that non-default settings for NLS_FIRST_DAY_OF_WEEK in the database may lead to unexpected results when aggregating by week.

As long as metabase/metabase#13496 is not implemented (which will allow drivers to read the current setting) we need to document this known issue.
@kaklakariada kaklakariada added the documentation Improvements or additions to documentation label Feb 2, 2023
@kaklakariada kaklakariada self-assigned this Feb 2, 2023
kaklakariada added a commit that referenced this issue Feb 2, 2023
@kaklakariada
#63 Document known issue with NLS_FIRST_DAY_OF_WEEK
db8a526
@kaklakariada kaklakariada mentioned this issue Feb 2, 2023
Merged
kaklakariada added a commit that referenced this issue Feb 3, 2023
@kaklakariada @ckunki
#63: Document known issue with NLS_FIRST_DAY_OF_WEEK (#64)
a061fc4 
* #59: Add integration test

* #59: Add tests

* Cleanup tests

* #63 Document known issue with `NLS_FIRST_DAY_OF_WEEK`

* Apply suggestions from code review

Co-authored-by: Christoph Kuhnke <github@kuhnke.net>

---------

Co-authored-by: Christoph Kuhnke <github@kuhnke.net>
@kaklakariada kaklakariada mentioned this issue Apr 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#63: Document known issue with NLS_FIRST_DAY_OF_WEEK exasol/metabase-driver
1 participant
@kaklakariada