Skip to content

Commit

Permalink
Renamed CLI option extract-timeout-minutes to deploy-timeout-minutes
Browse files Browse the repository at this point in the history
  • Loading branch information
ckunki committed Oct 14, 2024
1 parent e485862 commit d5ab544
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions exasol/python_extension_common/cli/std_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class StdParams(Enum):
alter_system = (StdTags.SLC, auto())
allow_override = (StdTags.SLC, auto())
wait_for_completion = (StdTags.SLC, auto())
extract_timeout_minutes = (StdTags.SLC, auto())
deploy_timeout_minutes = (StdTags.SLC, auto())
display_progress = (StdTags.SLC, auto())

def __init__(self, tags: StdTags, value):
Expand Down Expand Up @@ -160,7 +160,7 @@ def _get_param_name(std_param: StdParamOrName) -> str:
StdParams.alter_system: {'type': bool, 'default': True},
StdParams.allow_override: {'type': bool, 'default': False},
StdParams.wait_for_completion: {'type': bool, 'default': True},
StdParams.extract_timeout_minutes: {'type': int, 'default': 10},
StdParams.deploy_timeout_minutes: {'type': int, 'default': 10},
StdParams.display_progress: {'type': bool, 'default': True},
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def secret_callback(ctx: click.Context, param: click.Option, value: Any):
@click.option('--alter-system/--no-alter-system', type=bool, default=True)
@click.option('--allow-override/--disallow-override', type=bool, default=False)
@click.option('--wait_for_completion/--no-wait_for_completion', type=bool, default=True)
@click.option('--extract-timeout-minutes', type=int, default=10)
@click.option('--deploy-timeout-minutes', type=int, default=10)
@click.option('--display-progress/--no-display-progress', type=bool, default=True)
def language_container_deployer_main(
bucketfs_name: str,
Expand Down Expand Up @@ -185,7 +185,7 @@ def language_container_deployer_main(
alter_system: bool,
allow_override: bool,
wait_for_completion: bool,
extract_timeout_minutes: int,
deploy_timeout_minutes: int,
display_progress: bool,
container_url: Optional[str] = None,
container_name: Optional[str] = None):
Expand Down Expand Up @@ -219,7 +219,7 @@ def language_container_deployer_main(
ssl_client_certificate=ssl_client_cert_path,
ssl_private_key=ssl_client_private_key,
use_ssl_cert_validation=use_ssl_cert_validation,
extract_timeout=timedelta(minutes=extract_timeout_minutes),
deploy_timeout=timedelta(minutes=deploy_timeout_minutes),
display_progress=display_progress,
)

Expand Down
4 changes: 2 additions & 2 deletions test/unit/deployment/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def test_default_values(container_file):
OptionMapper("ssl_client_certificate", "", cli="--ssl-client-cert-path"),
OptionMapper("ssl_private_key", "", cli="--ssl-client-private-key"),
OptionMapper("use_ssl_cert_validation", True),
OptionMapper("extract_timeout", cli="--extract-timeout-minutes",
OptionMapper("deploy_timeout", cli="--deploy-timeout-minutes",
cli_value=5, value=timedelta(minutes=10)),
OptionMapper("display_progress", True),
]
Expand Down Expand Up @@ -193,7 +193,7 @@ def test_cli_options_passed_to_create(container_file):
OptionMapper("ssl_client_certificate", cli="--ssl-client-cert-path"),
OptionMapper("ssl_private_key", cli="--ssl-client-private-key"),
OptionMapper("use_ssl_cert_validation", False),
OptionMapper("extract_timeout", cli="--extract-timeout-minutes",
OptionMapper("deploy_timeout", cli="--deploy-timeout-minutes",
cli_value=6, value=timedelta(minutes=6)),
OptionMapper("display_progress", False),
]
Expand Down

0 comments on commit d5ab544

Please sign in to comment.