Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make open_pyexasol_connection(...) using kwargs with names defined in the StdParams #68

Closed
ahsimb opened this issue Oct 1, 2024 · 0 comments · Fixed by #71
Closed

Make open_pyexasol_connection(...) using kwargs with names defined in the StdParams #68

ahsimb opened this issue Oct 1, 2024 · 0 comments · Fixed by #71
Assignees
@ahsimb
Labels
refactoring Code improvement without behavior change

Comments

@ahsimb
Copy link
Collaborator

ahsimb commented Oct 1, 2024

The new signature should be

def open_pyexasol_connection(**kwargs) -> pyexasol.ExaConnection

where keys are defined by the exasol.pytho_extension_common.cli.std_options.StdParams.

To preserve compatibility the parameter translation hack db_pass -> StdParams.db_password.name should be implemented.
@ahsimb ahsimb added the refactoring Code improvement without behavior change label Oct 1, 2024
@ahsimb ahsimb changed the title Make open_pyexasol_connection(...) using kwargs with names defined by the StdParams Make open_pyexasol_connection(...) using kwargs with names defined in the StdParams Oct 1, 2024
@ahsimb ahsimb self-assigned this Oct 2, 2024
ahsimb added a commit that referenced this issue Oct 2, 2024
@ahsimb
#68 Updated the open_pyexasol_connection
9f3bd6c
ahsimb added a commit that referenced this issue Oct 2, 2024
@ahsimb
#68 Added open_pyexasol_connection_tests
c42eb7c
@ahsimb ahsimb mentioned this issue Oct 2, 2024
Merged
ahsimb added a commit that referenced this issue Oct 2, 2024
@ahsimb
#68 Restored the location of conftest.py
8283604
ahsimb added a commit that referenced this issue Oct 2, 2024
@ahsimb
#68 Fixed the open_pyexasol_connection onprem test
e6be949
ahsimb added a commit that referenced this issue Oct 2, 2024
@ahsimb @tomuben
#68 refactoring open_pyexasol_connection (#71)
566beab 
* Add documentation build folder to .gitignore

* #66 Standard CLI command builder

* Apply suggestions from code review

Co-authored-by: Thomas Ubensee <34603111+tomuben@users.noreply.github.com>

* #66 Addressed the review comments

* #68 Updated the open_pyexasol_connection

* #68 Added open_pyexasol_connection_tests

* #68 Restored the location of conftest.py

* #68 Fixed the open_pyexasol_connection onprem test

---------

Co-authored-by: Thomas Ubensee <34603111+tomuben@users.noreply.github.com>
@ahsimb ahsimb closed this as completed in #71 Oct 2, 2024
ahsimb added a commit that referenced this issue Oct 2, 2024
@ahsimb @tomuben
#69 Added create_bucketfs_location function (#72)
d181f23 
* Add documentation build folder to .gitignore

* #66 Standard CLI command builder

* Apply suggestions from code review

Co-authored-by: Thomas Ubensee <34603111+tomuben@users.noreply.github.com>

* #66 Addressed the review comments

* #68 Updated the open_pyexasol_connection

* #69 Added create_bucketfs_location function

* #68 Added open_pyexasol_connection_tests

* #69 Added tests for create_bucketfs_location

* #69 Updated the changelog

* #69 Restored the location of the conftest.py

* #69 Trying to fix the create_bucketfs_location tests

---------

Co-authored-by: Thomas Ubensee <34603111+tomuben@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahsimb ahsimb

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#68 refactoring open_pyexasol_connection exasol/python-extension-common
1 participant
@ahsimb