Bug fixing and moving to pytest plugins #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # exasol/python_extension_common/deployment/language_container_deployer.py # exasol/python_extension_common/deployment/language_container_deployer_cli.py # pyproject.toml # test/unit/deployment/test_language_container_deployer.py # test/unit/deployment/test_language_container_deployer_cli.py
tomuben
reviewed
Sep 20, 2024
tomuben
reviewed
Sep 20, 2024
tomuben
reviewed
Sep 20, 2024
| def test_language_container_builder(itde: config.TestConfig, | ||
| connection_factory: Callable[[config.Exasol], ExaConnection], | ||
| tmp_path): | ||
| def test_language_container_builder(deployer_factory, db_schema, language_alias, tmp_path): |
There was a problem hiding this comment.
tmp_path is not used anywhere here. Can it be removed?
tomuben
reviewed
Sep 20, 2024
| @@ -28,41 +20,34 @@ def test_prepare_flavor(tmp_path): | |||
| assert any(container_builder.wheel_target.iterdir()) | |||
|
|
|||
|
|
|||
| def test_prepare_flavor_extra(tmp_path): | |||
| def test_prepare_flavor_extra(tmp_path, language_alias): | |||
There was a problem hiding this comment.
tmp_path is not used anywhere here. Can it be removed?
tomuben
reviewed
Sep 20, 2024
|
|
||
|
|
||
| def test_prepare_flavor(tmp_path): | ||
| def test_prepare_flavor(tmp_path, language_alias): |
There was a problem hiding this comment.
tmp_path is not used anywhere here. Can it be removed?
tomuben
reviewed
Sep 20, 2024
| db_schema, | ||
| language_alias): | ||
| @contextmanager | ||
| def create_deployer(create_test_schema: bool = False): |
There was a problem hiding this comment.
The meaning of the boolean parameter is not very obvious reading the code of the tests below. Would it be better to use a **argv here, so that clients are forced to use deployed_factor(create_schema=True)?
There was a problem hiding this comment.
**kwaargs won't make it easier to understand the meaning of the parameter by looking at the method signature. I will change all calls to include the parameter name.
tomuben
previously approved these changes
Sep 20, 2024
tomuben
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #58
closes #35
closes #36