Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor C layer #63

Closed
tomuben opened this issue Jul 7, 2021 · 0 comments
Closed

Refactor C layer #63

tomuben opened this issue Jul 7, 2021 · 0 comments
Assignees
@tomuben
Labels
refactoring Code improvement without behavior change

Comments

@tomuben
Copy link
Collaborator

tomuben commented Jul 7, 2021

Background

In preparation of #56 we need to refactor the C code, and support C++ unit test.

Acceptance Criteria

The r-exasol library should be prepared to implement C++ unit tests and can be implemented in C++.
@tomuben tomuben added refactoring Code improvement without behavior change source:exasol labels Jul 7, 2021
@tomuben tomuben self-assigned this Jul 7, 2021
@tomuben tomuben closed this as completed in 0b693a7 Aug 9, 2021
@tomuben tomuben mentioned this issue Oct 11, 2021
Closed
tomuben added a commit that referenced this issue Oct 11, 2021
@tomuben
#103: exa.ReadData not working correctly under Windows
95dd2c1 
RCA:
During the refactoring (#63),
the magic number = 1 for closing the socket for sending was
replaced with SD_RECEIVE, but it should have been replaced with SD_SEND.
The consequence was that the socket might have been closed
before the ok answered was sent to the database.

Fix:
Replace SD_RECEIVE with SD_SEND
@tomuben tomuben mentioned this issue Oct 11, 2021
Merged
tomuben added a commit that referenced this issue Oct 12, 2021
@tomuben
#103: exa.ReadData not working correctly under Windows
e0cda0a 
RCA:
During the refactoring (#63),
the magic number = 1 for closing the socket for sending was
replaced with SD_RECEIVE, but it should have been replaced with SD_SEND.
The consequence was that the socket might have been closed
before the ok answered was sent to the database.

Fix:
Replace SD_RECEIVE with SD_SEND
tomuben added a commit that referenced this issue Oct 12, 2021
@tomuben
#103: exa.ReadData not working correctly under Windows (#104)
0bcac51 
RCA:
During the refactoring (#63),
the magic number = 1 for closing the socket for sending was
replaced with SD_RECEIVE, but it should have been replaced with SD_SEND.
The consequence was that the socket might have been closed
before the ok answered was sent to the database.

Fix:
Replace SD_RECEIVE with SD_SEND

Fixes #103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomuben tomuben

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomuben