Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate results for tests and security scan #34

Closed
Tracked by #819
tkilias opened this issue Jun 1, 2023 · 2 comments · Fixed by #36
Closed
Tracked by #819

Validate results for tests and security scan #34

tkilias opened this issue Jun 1, 2023 · 2 comments · Fixed by #36
Assignees
@tkilias @ckunki
Labels
bug Unwanted / harmful behavior

Comments

@tkilias
Copy link
Collaborator

tkilias commented Jun 1, 2023

Background

  • Currently, the CI runs don't fail when tests or the security scan fail
  • We only return the results without validating them
@tkilias tkilias added the bug Unwanted / harmful behavior label Jun 1, 2023
@tkilias tkilias mentioned this issue Jun 5, 2023
Closed
3 tasks
@tkilias tkilias self-assigned this Jun 6, 2023
@tkilias tkilias mentioned this issue Jun 8, 2023
Merged
@ckunki ckunki self-assigned this Jun 9, 2023
@ckunki
Copy link
Contributor

ckunki commented Jun 9, 2023

Hi @tkilias initial review done. I am happy to have a short diiscussion.

@ckunki
Copy link
Contributor

ckunki commented Jun 13, 2023 •
edited
Loading

Review round 2 done. See findings in PR.

tkilias added a commit that referenced this issue Jun 14, 2023
@tkilias @ckunki
#34: Added validation for results of tests and security_scan (#36)
a812e86 
* Introduced dependency injection for easier testing
* Added unit tests for ci_test

Co-authored-by: Christoph Kuhnke <github@kuhnke.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkilias tkilias

@ckunki ckunki

Labels
bug Unwanted / harmful behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#34: Added validation for results of tests and security_scan exasol/script-languages-container-ci
2 participants
@tkilias @ckunki