-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exaslct does not throw an error when it fails to install an R package #772
Comments
The reason for this bug is that the package installation of R doesn't fail when packages can't be installed. It only shows it in the logs, which can't be easily searched. There are potentially a few options to solve this issue. Some discussion regarding this issue: https://stackoverflow.com/questions/26244530/how-do-i-make-install-packages-return-an-error-if-an-r-package-cannot-be-install
The first solution doesn't guarantee to find all issues during installation, but would fail fast. The second one only guarantees that the package was installed, but not that it is loadable. The third one guarantees that a package is loadable, but not that it works. I suggest implementing 1. and 2. as part of the installation script and 3. and 4. for important packages. |
Maybe option 3 can also be automated, but we probably should use the list of installed.packages() instead our list, in case packages get installed from a Github repository |
Acceptance Criteria
|
Steps to reproduce
Hmisc
R pkg toflavor_customization/packages/r_cran_packages
exaslct build --flavor-path ./flavors/standard-EXASOL-7.1.0
-> builds the image without errorslibrary(Hmisc
) -> ObserveThe text was updated successfully, but these errors were encountered: