Check that the user provided host parameter value is an IP address #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help to fail-fast if users provide a domain name or non-ip value for the host parameter when using the Spark Exasol connector.
3cham
approved these changes
Jul 10, 2019
| @@ -51,14 +53,25 @@ final case class ExasolConfiguration( | |||
|
|
|||
| object ExasolConfiguration { | |||
|
|
|||
| val IPv4_DIGITS: String = "(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)" | |||
There was a problem hiding this comment.
Since this rule accepts 192.168.2.01 as valid address, I don't know if sub-connection could resolve this address (ping does). I'm currently having problem running it tests with my mac so I cannot verify it. Maybe could you please quickly check with our cluster @jpizagno ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help to fail-fast if users provide a domain name or non-ip value for the host parameter when using the Spark Exasol connector.
Fixes #43.