Remove NOT NULL constraint from String types.
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We create an Exasol table, if it did not exist, before saving the Spark dataframe. The `NOT NULL` constraint was added to the create table DDL, if the Spark schema field type is not nullable. However, this can be problem in Exasol side. Because, Exasol puts `null` if the string is empty for `VARCHAR` or `CLOB` column types. Therefore, putting not null constraints fails when inserting empty strings. This commit removes the `NOT NULL` constraints from string types even if they are not nullable. Fixes #60.
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 84.43% 84.43%
=======================================
Files 11 11
Lines 469 469
Branches 58 58
=======================================
Hits 396 396
Misses 73 73
Continue to review full report at Codecov.
|
|
LGTM :) thanks @morazow for working on this |
3cham
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create an Exasol table, if it did not exist, before saving the Spark
dataframe. The
NOT NULLconstraint was added to the create table DDL,if the Spark schema field type is not nullable.
However, this can be problem in Exasol side. Because, Exasol puts
nullif the string is empty for
VARCHARorCLOBcolumn types. Therefore,putting not null constraints fails when inserting empty strings.
This commit removes the
NOT NULLconstraints from string types even ifthey are not nullable.
Fixes #60.