Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BooleanExpressionVisitor #100

Closed
jakobbraun opened this issue Oct 27, 2020 · 1 comment · Fixed by #101
Closed

Refactor BooleanExpressionVisitor #100

jakobbraun opened this issue Oct 27, 2020 · 1 comment · Fixed by #101
Labels
refactoring Code improvement without behavior change

Comments

@jakobbraun
Copy link
Contributor

Currently, BooleanExpressionVisitor uses visit and leave. I've got the feeling that it would be better style to only use visit in combination with recursive calls, but I'm not sure about that.
@jakobbraun jakobbraun added the refactoring Code improvement without behavior change label Oct 27, 2020
@jakobbraun
Copy link
Contributor Author

jakobbraun commented Oct 27, 2020 •
edited
Loading

By that we could also rewrite the current logic:

connect(and);
this.connectorDeque.push(" AND ");

to something more readable like
Sering.joing("AND", ...)

@jakobbraun jakobbraun mentioned this issue Oct 28, 2020
Merged
@jakobbraun jakobbraun linked a pull request Oct 28, 2020 that will close this issue
Refactor/95 value expression visitor #101
Merged
@jakobbraun jakobbraun mentioned this issue Oct 30, 2020
Closed
@kaklakariada kaklakariada mentioned this issue Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/95 value expression visitor exasol/sql-statement-builder
1 participant
@jakobbraun