Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ColumnsDefinitionRenderer #102

Closed
jakobbraun opened this issue Oct 30, 2020 · 1 comment · Fixed by #120
Closed

Refactor ColumnsDefinitionRenderer #102

jakobbraun opened this issue Oct 30, 2020 · 1 comment · Fixed by #120
Assignees
@kaklakariada
Labels
refactoring Code improvement without behavior change

Comments

@jakobbraun
Copy link
Contributor

Refactor ColumnsDefinitionRenderer like #100
@jakobbraun jakobbraun mentioned this issue Oct 30, 2020
Merged
@jakobbraun
Copy link
Contributor Author

When fixed, remove double spaces from CastExasolFunctionTest again

@redcatbear redcatbear added the refactoring Code improvement without behavior change label Feb 26, 2021
@kaklakariada kaklakariada self-assigned this Sep 23, 2021
kaklakariada added a commit that referenced this issue Sep 23, 2021
@kaklakariada
#102: Refactor ColumnsDefinitionRenderer to remove the leave() method
89e4d9b
@kaklakariada kaklakariada mentioned this issue Sep 23, 2021
Merged
kaklakariada added a commit that referenced this issue Sep 27, 2021
@kaklakariada
Refactor/102_refactor_ColumnsDefinitionRenderer (#120)
f4338fb 
* #102: Refactor ColumnsDefinitionRenderer to remove the leave() method

* Add tests with empty column list

* Update changelog

* Implement review findings

* Upgrade github-pages-deploy-action
@kaklakariada kaklakariada mentioned this issue Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/102_refactor_ColumnsDefinitionRenderer exasol/sql-statement-builder
3 participants
@redcatbear @kaklakariada @jakobbraun